Created attachment 1397728 [details] Patch for passing "user" and "remotename" options to pppd Description of problem: Plugin doesn't pass "user" and "remotename" options to pppd Version-Release number of selected component (if applicable): Plugin doesn't pass "user" and "remotename" options to pppd How reproducible: Normal use Steps to Reproduce: 1. Configure VPN connection through NetworkManager pptp plugin 2. Try to establish connection Actual results: pppd can't establish connection Expected results: Connection must be established Additional info: Need to add attached patch and modify spec as --- NetworkManager-pptp.spec_orig 2018-02-19 03:01:12.762515208 +0300 +++ NetworkManager-pptp.spec 2018-02-12 03:04:22.564243321 +0300 @@ -8,6 +8,8 @@ Group: System Environment/Base Source0: https://download.gnome.org/sources/NetworkManager-pptp/1.2/%{name}-%{version}.tar.xz +Patch0001: user_remotename.patch + %global ppp_version %(sed -n 's/^#define\\s*VERSION\\s*"\\([^\\s]*\\)"$/\\1/p' %{_includedir}/pppd/patchlevel.h 2>/dev/null | grep . || echo bad) BuildRequires: gtk3-devel @@ -47,6 +49,7 @@ %prep %setup -q +%autopatch -p2 %build %configure \
Please create patches against upstream first (https://git.gnome.org/browse/network-manager-pptp , against branch "master". Please create patches with `git format-patch`, and provide a good commit message (https://chris.beams.io/posts/git-commit/#seven-rules might be a good help) It's fine to attach the patch on the this downstream bug-tracker. If you have difficulties using git, please state your preferred "Firstname Surname <email>" for the authorship of the patch here and somebody will create the upstream commit. Thanks.
Created attachment 1413102 [details] Patch against master in "git format-path" format [PATCH] Fix passing "user" field and add passing "remotename"
Comment on attachment 1413102 [details] Patch against master in "git format-path" format Same patch is upstream at https://bugzilla.gnome.org/show_bug.cgi?id=794695
Fixed upstream: https://git.gnome.org/browse/network-manager-pptp/commit/?id=ab6a989f424b84e26167634238392e43d601ff89
NetworkManager-pptp-1.2.6-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3ddd53ddbc
NetworkManager-pptp-1.2.6-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3ddd53ddbc
NetworkManager-pptp-1.2.6-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.