RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1547238 - broken probe vfs.add_to_page_cache
Summary: broken probe vfs.add_to_page_cache
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: systemtap
Version: 7.4
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Frank Ch. Eigler
QA Contact: Martin Cermak
URL:
Whiteboard:
Depends On:
Blocks: 1477664
TreeView+ depends on / blocked
 
Reported: 2018-02-20 20:13 UTC by Paulo Andrade
Modified: 2021-12-10 15:42 UTC (History)
5 users (show)

Fixed In Version: systemtap-3.3-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-30 10:46:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:3168 0 None None None 2018-10-30 10:47:19 UTC

Description Paulo Andrade 2018-02-20 20:13:40 UTC
This might be reassigned to kernel, as it is broken since rhel7
kernel commit 06c42e3f5156a048a2e50ec013646bfdda916688 that does
some shortcuts, with the side effect of not triggering the probes.

  From my understanding of the semantics, the new patch should not
have the "!" operator, so, fixing this issue only on rhel7 would
require this patch:

"""
--- /usr/share/systemtap/tapset/linux/vfs.stp.orig
+++ /usr/share/systemtap/tapset/linux/vfs.stp
@@ -862,8 +862,8 @@
 }
 
 probe vfs.add_to_page_cache =
-	kernel.function("add_to_page_cache_locked") !,
-	kernel.function("add_to_page_cache")
+	kernel.function("add_to_page_cache_lru"),
+	kernel.function("add_to_page_cache_locked")
 {
 	dev = $mapping->host->i_sb->s_dev
 	devname = __find_bdevname(dev, $mapping->host->i_sb->s_bdev)
@@ -879,8 +879,8 @@
 }
 
 probe vfs.add_to_page_cache.return =
-	kernel.function("add_to_page_cache_locked").return !,
-	kernel.function("add_to_page_cache").return
+	kernel.function("add_to_page_cache_lru").return,
+	kernel.function("add_to_page_cache_locked").return
 {
 	name = "vfs.add_to_page_cache"
 	retstr = sprintf("%d", $return)
"""

quick and dirty test case is:

"""
#!/bin/stap

probe vfs.add_to_page_cache {
	printf("%s\n", probefunc());
}
"""

Comment 2 Frank Ch. Eigler 2018-06-12 23:02:51 UTC
Commit e40b26c5bbaa (based on your patch) should fix this.
 http://tinyurl.com/y7wo82km

Comment 7 errata-xmlrpc 2018-10-30 10:46:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:3168


Note You need to log in before you can comment on or make changes to this bug.