Bug 1547515 - atlas: Partial injection of Fedora build flags
Summary: atlas: Partial injection of Fedora build flags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: atlas
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jakub Martisko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-21 13:19 UTC by Florian Weimer
Modified: 2018-04-30 21:17 UTC (History)
5 users (show)

Fixed In Version: atlas-3.10.3-5.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-30 21:17:54 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2018-02-21 13:19:48 UTC 
/usr/lib64/atlas/libsatlas.so.3.10 in atlas-3.10.3-3.fc28.x86_64 does not use the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

The linker invocations look like this:

/usr/bin/x86_64-redhat-linux-gcc  -g -Wa,--noexecstack -fPIC -m64 -shared -o libsatlas.so.3.10  \
           \
           -Wl,-soname,"libsatlas.so.3" \
           -Wl,--whole-archive liblapack.a libf77blas.a libcblas.a libatlas.a /builddir/build/BUILD/ATLAS/liblapack_pic_pruned.a -Wl,--no-whole-archive -L/usr/lib/gcc/x86_64-redhat-linux/8 -lgfortran  -lc -lpthread -lm -lgcc

No LDFLAGS are used there.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.
Comment 1 Jakub Martisko 2018-04-24 07:55:00 UTC 
Added RPM_LD_FLAGS. The last rawhide build [1] looks like this:

/usr/bin/x86_64-redhat-linux-gcc  -g -Wa,--noexecstack -fPIC -Wl,-z,relro  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -m64 -shared -o libsatlas.so.3.10  \
           \
           -Wl,-soname,"libsatlas.so.3" \
           -Wl,--whole-archive liblapack.a libf77blas.a libcblas.a libatlas.a /builddir/build/BUILD/ATLAS/liblapack_pic_pruned.a -Wl,--no-whole-archive -L/usr/lib/gcc/x86_64-redhat-linux/8 -lgfortran  -lc -lpthread -lm -lgcc

Feel free to reopen if there are still any problems.

[1]: https://koji.fedoraproject.org/koji/buildinfo?buildID=1068839
Comment 2 Florian Weimer 2018-04-24 15:05:05 UTC 
Looks better, thanks.  Would you please put this into Fedora 28 as well, via an update through Bodhi?
Comment 3 Fedora Update System 2018-04-26 08:03:02 UTC 
atlas-3.10.3-5.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1cff122c3d
Comment 4 Fedora Update System 2018-04-26 15:33:36 UTC 
atlas-3.10.3-5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1cff122c3d
Comment 5 Fedora Update System 2018-04-30 21:17:54 UTC 
atlas-3.10.3-5.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.