Bug 1547553 - Error: rpmbuild -bs --with vanilla kernel.spec
Summary: Error: rpmbuild -bs --with vanilla kernel.spec
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-21 14:21 UTC by Nick Lee
Modified: 2021-09-27 19:04 UTC (History)
19 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-29 15:14:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix (5.77 KB, patch)
2019-06-23 09:33 UTC, Jan Kratochvil
no flags Details | Diff
Fix#2 (6.06 KB, patch)
2019-06-23 09:55 UTC, Jan Kratochvil
no flags Details | Diff

Description Nick Lee 2018-02-21 14:21:00 UTC
$ rpmbuild -bs --with vanilla kernel.spec
error: line 381: Invalid version (double separator '-'): 4.15.3-300.fc27.x86_64-vanilla: Requires: kernel-core-uname-r = 4.15.3-300.fc27.x86_64-vanilla

Comment 1 Laura Abbott 2018-02-21 19:47:29 UTC
The variant should probably be removed, especially since it looks like the vanilla repositories (https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories) just comment it out.

Comment 2 Thorsten Leemhuis 2018-02-21 20:53:05 UTC
(In reply to Laura Abbott from comment #1)
> The variant should probably be removed, especially since it looks like the
> vanilla repositories just comment it out.

FWIW: The FAQ contains some of the reasons why I chose to do so:
https://fedoraproject.org/wiki/Kernel_Vanilla_Repositories-FAQ#Why_did_you_drop_the_.27-vanilla.27_postfix_that_normally_gets_added_to_the_.27name.27_macro_when_you_build_Fedora.27s_kernel_RPM_without_patches_locally.3F
But maybe some of those reasons are not valid anymore, as kernel.spec changed since then.

I don't have much of an option how to deal with this bug.  Dropping is fine for me. But it wsa introduced for a reasons iirc: have something in the name and/or verrel to indicate that a package was build using "--with vanilla". If the kernel team would like to see such and indicator it might be enough to simply do a "s!-!.!" on "%define variant -vanilla"; or maybe make "buildid" automatically add a ".vanilla" if the spec file if build with "--with vanilla" (guess that's the solution I'd aim for; side note:  I add a ".vanilla" in my packages there, too).

Comment 3 Justin M. Forbes 2018-07-23 15:21:10 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 27 kernel bugs.

Fedora 27 has now been rebased to 4.17.7-100.fc27.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 28, and are still experiencing this issue, please change the version to Fedora 28.

If you experience different issues, please open a new bug report for those.

Comment 4 Justin M. Forbes 2018-08-29 15:14:24 UTC
*********** MASS BUG UPDATE **************
This bug is being closed with INSUFFICIENT_DATA as there has not been a response in 5 weeks. If you are still experiencing this issue, please reopen and attach the relevant data from the latest kernel you are running and any data that might have been requested previously.

Comment 5 Jan Kratochvil 2019-06-23 09:33:57 UTC
Created attachment 1583656 [details]
Fix

Still affects: kernel-5.2.0-0.rc5.git4.1.fc31

Comment 6 Jan Kratochvil 2019-06-23 09:55:37 UTC
Created attachment 1583668 [details]
Fix#2


Note You need to log in before you can comment on or make changes to this bug.