Bug 1547814 - gdeploy should stop execution once the VDO volume creation fails
Summary: gdeploy should stop execution once the VDO volume creation fails
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: gdeploy
Version: rhgs-3.3
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
: RHGS 3.3.1 Async
Assignee: Ramakrishna Reddy Yekulla
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1547813 1581561
TreeView+ depends on / blocked
 
Reported: 2018-02-22 02:36 UTC by SATHEESARAN
Modified: 2018-06-21 03:34 UTC (History)
9 users (show)

Fixed In Version: gdeploy-2.0.2-26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1547813
Environment:
Last Closed: 2018-06-21 03:33:15 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:1958 0 None None None 2018-06-21 03:34:48 UTC

Description SATHEESARAN 2018-02-22 02:36:40 UTC
+++ This bug was initially created as a clone of Bug #1547813 +++

Description of problem:
-----------------------
When the creation of VDO volume fails, gdeploy should halt the execution.
The expectation here is the availability of the param 'ignore_vdo_failure' similar to the ones under 'vg' & 'lv'

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gdeploy-2.0.2-22.el7rhgs

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Provide a non-available device for VDO volume creation in gdeploy conf file
2. Execute the conf file

Actual results:
---------------
gdeploy ignore errors when VDO volume creation fails and proceeds to further tasks

Expected results:
----------------
gdeploy should provide an option 'ignore_vdo_errors' there gdeploy could halt the execution on encountering errors

Additional info:
----------------
For example this is the gdeploy conf file used:
[hosts]
host1

[vdo]
action=create
devices=sdz
names=vdovol1
logicalsize=100G
ignore_vdo_errors=no

And here is the console output with the above mentioned gedploy conf file:

# gdeploy -c vdocreate.conf 

PLAY [gluster_servers] ********************************************************************************************************************************************************************************************

TASK [Create VDO with specified size] *****************************************************************************************************************************************************************************
failed: [10.70.36.244] (item={u'disk': u'/dev/sdz', u'logicalsize': u'100G', u'name': u'vdovol1'}) => {"changed": false, "err": "vdo: ERROR -   Device /dev/sdz not found.\n", "item": {"disk": "/dev/sdz", "logicalsize": "100G", "name": "vdovol1"}, "msg": "Creating VDO vdovol1 failed.", "rc": 2}
	to retry, use: --limit @/tmp/tmpaanGEu/vdo-create.retry

PLAY RECAP ********************************************************************************************************************************************************************************************************
10.70.36.244               : ok=0    changed=0    unreachable=0    failed=1   

Ignoring errors...

Comment 3 Devyani Kota 2018-04-20 07:52:00 UTC
This commit[1] fixes this issue.

[1]https://github.com/gluster/gdeploy/pull/502/commits/99e6e0bb721d48a835ca4daec743dd202958c3a3

Thanks.

Comment 4 SATHEESARAN 2018-05-02 10:39:05 UTC
Tested with gdeploy-2.0.2-26.el7rhgs

When 'ignore_vdo_errors=no' is available in the VDO section, VDO halts execution on encoutering errors.

Comment 6 errata-xmlrpc 2018-06-21 03:33:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1958


Note You need to log in before you can comment on or make changes to this bug.