Bug 1547844

Description of problem:

The binary for 32 bit Windows platform will not build do to the value for  fromCIDR() being set to 0XFFFFFFFF and hitting the upper bound for 32 bit non

Version-Release number of selected component (if applicable):

>= OCP 3.7

How reproducible:

Always

Steps to Reproduce:

# make all OS_BUILD_PLATFORMS=windows/386 WHAT=cmd/oc

Fails with an integer overflow error in ipv4range.go.

Actual results:

$ make all OS_BUILD_PLATFORMS=windows/386 WHAT=cmd/oc
hack/build-go.sh cmd/oc
++ Building go targets for windows/386: cmd/oc
# github.com/openshift/origin/pkg/oc/bootstrap/docker/dockerhelper
pkg/oc/bootstrap/docker/dockerhelper/ipv4range.go:106:22: constant 4294967295 overflows int
[ERROR] PID 24110: hack/lib/build/binaries.sh:235: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"` exited with status 2.
[INFO]         Stack Trace:
[INFO]           1: hack/lib/build/binaries.sh:235: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"`
[INFO]           2: hack/lib/build/binaries.sh:156: os::build::internal::build_binaries
[INFO]           3: hack/build-go.sh:25: os::build::build_binaries
[INFO]   Exiting with code 2.
[ERROR] PID 24039: hack/lib/build/binaries.sh:150: `local -a binaries=("$@")` exited with status 2.
[INFO]         Stack Trace:
[INFO]           1: hack/lib/build/binaries.sh:150: `local -a binaries=("$@")`
[INFO]           2: hack/build-go.sh:25: os::build::build_binaries
[INFO]   Exiting with code 2.
[ERROR] hack/build-go.sh exited with code 2 after 00h 04m 23s
make: *** [all] Error 2

Expected results:

Successful build.

Additional info:

I know that we do not build or release the 32 bit binaries of the oc command, but this change allows users to build the binaries themselves.

Pull Request upstream":

https://github.com/openshift/origin/pull/18653