Bug 1548371
| Summary: | default release pointer key 'Ctrl+Alt' is not accurate | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Xiaodai Wang <xiaodwan> |
| Component: | virt-viewer | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | --- | CC: | juzhou, knoel, mxie, mzhan, rbalakri, tzheng, uril, victortoso |
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | virt-viewer-9.0-5.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-18 15:53:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xiaodai Wang
2018-02-23 10:52:27 UTC
Improving UI/UX. Moving to RHEL 8 Looking at code:
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_Delete, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+_Del"), "<virt-viewer>/send/secure-attention"},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_BackSpace, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+_Backspace"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F1, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_1"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F2, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_2"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F3, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_3"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F4, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_4"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F5, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_5"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F6, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_6"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F7, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_7"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F8, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_8"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F9, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_9"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F10, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F1_0"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F11, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F11"), NULL},
./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F12, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F12"), NULL},
most of the combinations require only left modifiers (control and alt) but the comment does not state that.
(In reply to Frediano Ziglio from comment #3) > Looking at code: > > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_Delete, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+_Del"), > "<virt-viewer>/send/secure-attention"}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_BackSpace, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+_Backspace"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F1, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_1"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F2, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_2"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F3, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_3"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F4, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_4"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F5, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_5"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F6, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_6"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F7, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_7"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F8, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_8"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F9, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F_9"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F10, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F1_0"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F11, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F11"), NULL}, > ./src/virt-viewer-window.c: { { GDK_KEY_Control_L, GDK_KEY_Alt_L, > GDK_KEY_F12, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F12"), NULL}, > > most of the combinations require only left modifiers (control and alt) but > the comment does not state that. Ignore, the keys above are sent to the guest. Maybe replace the "Ctrl+Alt" string with "LCtrl+LAlt" ? or "LeftCtrl+LeftAlt" ? Upstream patch accepted Patch accepted and merged upstream, see https://gitlab.com/virt-viewer/virt-viewer/-/commit/ae25f6ca6b46e95281186492de5bc0a0fe4974a6 I can reproduce this issue with build: virt-viewer-9.0-4.el8.x86_64 Then try to verify this bug with new build: Step: 1. Prepare a guest which can grasp mouse pointer. 2. Keep release pointer key as default 'ctrl+alt' 3. Open the guest by virt-viewer and click the guest to grasp the mouse pointer. $ virt-viewer -c qemu:///system rhel8.3 4. Check the title is 'Press Ctrl_L+Alt_L to release pointer xxx' The mouse can only be released by left control + left alt, and right control + right alt doesn't work. Summary: The default key accelerator to release mouse if left control and left alt and the description has changed to "Ctrl_L+Alt_L" to avoid misunderstanding. I move this bug from ON_QA to VERIFIED, thanks. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt-viewer bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:1876 |