Bug 1548389 - audit.log should not contain translated messages
Summary: audit.log should not contain translated messages
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.10.0
Assignee: Milan Zázrivec
QA Contact: Angelina Vasileva
URL:
Whiteboard:
Depends On:
Blocks: 1553322
TreeView+ depends on / blocked
 
Reported: 2018-02-23 11:47 UTC by Milan Zázrivec
Modified: 2019-04-25 13:08 UTC (History)
8 users (show)

Fixed In Version: 5.10.0.26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1553322 (view as bug list)
Environment:
Last Closed: 2019-02-11 13:59:23 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Milan Zázrivec 2018-02-23 11:47:46 UTC
Description of problem:
Appliance's audit.log should not contain translated messages. 

Version-Release number of selected component (if applicable):
CFME 5.9

How reproducible:
Always

Steps to Reproduce:
1. Switch your appliance to non-English locale and use it for a while
2. After a while, check the audit.log on the appliance

Actual results:
audit.log contains translated messages.


Expected results:
audit.log should not contain translated messages.

Additional info:
N/A

Comment 2 Dave Johnson 2018-02-23 12:04:36 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 4 Angelina Vasileva 2018-11-20 08:46:07 UTC
5.10.0.24.20181113213923_03b81fd

I switched the appliance to Spanish and monitored the audit.log and got log messages in Spanish, e.g.:

[----] I, [2018-11-20T03:22:42.268520 #15259:37c5bc0]  INFO -- Success: MIQ(EmsCommonHelper.add_success_audit) userid: [admin] - 'refresh_ems' iniciada correctamente para Ems infra


[----] I, [2018-11-20T03:34:26.296270 #15259:37c58c8]  INFO -- Success: MIQ(OpsRbac.rbac_edit_save_or_add) userid: [admin] - Registro [username] actualizado ( name:[aaa] a [username],  email:[aaa] a [user],  userid:[aaa] a [username])

[----] I, [2018-11-20T03:35:37.702907 #15259:37c5bc0]  INFO -- Success: MIQ(OpsRbac.rbac_edit_save_or_add) userid: [admin] - Registro [new_group] agregado ( filter_expression:[{"???"=>"???"}] a [],  description:[] a [new_group],  role:[] a [4],  group_tenant:[] a [1])

Comment 6 CFME Bot 2018-11-23 14:47:22 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e2a64ab62341dd615e744d7e03f9f41c432694f0
commit e2a64ab62341dd615e744d7e03f9f41c432694f0
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Nov 21 06:37:29 2018 -0500
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Nov 21 06:37:29 2018 -0500

    EmsCommonHelper: don't translate audit messages

    https://bugzilla.redhat.com/show_bug.cgi?id=1548389

 app/controllers/ems_common_helper.rb | 7 +-
 1 file changed, 5 insertions(+), 2 deletions(-)

Comment 7 CFME Bot 2018-11-27 14:52:21 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/8039fe91d9be969a1953f719af811d26fd4f391f
commit 8039fe91d9be969a1953f719af811d26fd4f391f
Author:     Martin Povolny <mpovolny>
AuthorDate: Fri Nov 23 09:43:27 2018 -0500
Commit:     Martin Povolny <mpovolny>
CommitDate: Fri Nov 23 09:43:27 2018 -0500

    Merge pull request #4952 from mzazrivec/dont_translate_audit_messages

    Don't translate audit messages

    (cherry picked from commit 7cf753b40c73b3df183805931695503f20e658f7)

    https://bugzilla.redhat.com/show_bug.cgi?id=1548389

 app/controllers/ems_common_helper.rb | 7 +-
 app/controllers/ops_controller.rb | 16 +-
 2 files changed, 13 insertions(+), 10 deletions(-)

Comment 8 Angelina Vasileva 2018-12-11 13:54:17 UTC
Fixed and verified in 5.10.0.28.20181204160308_aa3b074


Note You need to log in before you can comment on or make changes to this bug.