Bug 1548419
| Summary: | Spice agent is stuck after closing connection with ongoing file transfer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Radek Duda <rduda> | ||||||
| Component: | spice-vdagent-win | Assignee: | Frediano Ziglio <fziglio> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | --- | CC: | cfergeau, dblechte, fziglio, lsurette, spice-qe-bugs, srevivo, tpelka, uril, victortoso | ||||||
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | spice-vdagent-win-0.10.0-4 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2020-11-04 03:17:29 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Spice | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Easy to reproduce upstream too, you just need to drag'n drop a big file and closed the connection. Both VDagent and VDservice are running but stuck and Spice features do not work after Agent enter in this state. Moving to 4.3 for now and if needed we can backport to 4.2.z Verified that this is solved in git master but bug still happens on latest release 0.9.0. We should make a release soon and probably rebase to bring several fixes to rhv.
I'd guess the fix to be the commit below but I didn't bisect the code for it.
commit aefc220c027c98c0877cbb6dc7140e72f119262b
Author: Frediano Ziglio <fziglio>
Date: Fri May 25 20:01:11 2018 +0100
file_xfer: Use destructor for FileXferTask
Limit too much manual work.
By default delete the file, unless success() is called.
Signed-off-by: Frediano Ziglio <fziglio>
Acked-by: Christophe Fergeau <cfergeau>
Moving to POST, checking for rebase on vdagent soon and I'll make this bug to depend on it (to be checked if really fixed, etc.)
This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1. 4.3.1 has been released, please re-target this bug as soon as possible. From Comment #2 this is not reproducible upstream. Need to find the proper fix as suggested commit did not fix it. Perhaps we could do a rebase to match upstream too? Moving back to NEW. Removing myself from ASSIGNED. Even current master is not happy about it. It seems most of the time after you close the connection while transfering the file then the agent/service is not able to work. But processes are still there (as Victor state in a previous comment) and CPU is 0% (so not in a loop). The issue is that large messages (like chunks of file) are split into chunks. When there's a disconnection server sends a VD_AGENT_DISCONNECT to the agent but it could be that _in_msg_pos is >0 that is the message was incomplete. This will cause next chunks to be added to the old incomplete one instead of creating a new message. Solution is simple reset _in_msg_pos (and relative) when server sends VD_AGENT_CLIENT_DISCONNECTED. Created attachment 1688941 [details]
Proposed fix
Merged as fa2e3371c8a1cc3038039d08e13a289ae4fdb207 *** Bug 1676919 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (spice-vdagent-win bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:4721 |
Created attachment 1399858 [details] vdagent.log from Win10 guest Description of problem: If I close remote-viewer when file is trranserred (drag'n'drop from client to guest), vdservice is stopped. Version-Release number of selected component (if applicable): client/host rhel7.5: virt-viewer-5.0-10.el7.x86_64 spice-server-0.14.0-2.el7.x86_64 spice-glib-0.34-3.el7.x86_64 spice-gtk3-0.34-3.el7.x86_64 qemu-kvm-rhev-2.9.0-16.el7_4.14.x86_64 guest Win10/Win7: vdagent-win-4.1-5 everything from RHEV-tools 4.2-2 How reproducible: ~70% Steps to Reproduce: 1. Start Win VM, connect to it with remote-viewer 2. drag'n'drop some file from client to guest 3. before transfer is complete close remote-viewer 4. reconnect to guest VM with remote-viewer if vdagent is running repeat steps 2-4 Actual results: vdservice is not working Expected results: vdservice is running Additional info: