Bug 1548433 - dyninst-testsuite not built with Fedora build flags
Summary: dyninst-testsuite not built with Fedora build flags
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: dyninst
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stan Cox
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-23 14:06 UTC by Florian Weimer
Modified: 2019-11-27 22:53 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 22:53:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-02-23 14:06:04 UTC
The binaries in /usr/lib64/dyninst/testsuite in dyninst-testsuite-9.3.2-10.fc28.x86_64 have not been built with the Fedora build flags.

First, this causes them to show up as hardening failures in my reports.  Second, I think it is important to test that dyninst works for Fedora-built binaries, too, so using the standard flags makes sense for the test suite, too.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Rafael Fonseca 2018-05-28 15:44:12 UTC
Do you know which binaries? Looking at the log of the latest build, the flags seem to be applied: https://kojipkgs.fedoraproject.org//packages/dyninst/9.3.2/11.fc28/data/logs/x86_64/build.log

Comment 2 Igor Raits 2018-07-21 07:41:32 UTC
ping?

Comment 3 Florian Weimer 2018-07-23 12:02:39 UTC
For example, /usr/lib64/dyninst/testsuite/test_thread_6.dyn_g++_64_pic_none has not been linked with -Wl,-z,now and is not PIE.

On rawhide, you can use annocheck to check for incorrect build flags, but there will be lots of reports for the statically linked binaries for technical reasons (not all of glibc can be built with the Fedora flags, so there are many exceptions/hardening gaps in a statically linked applications).  For dynamically linked executables, there will be some false positives related to _dl_relocate_static_pie and static_reloc.c_end, but these should go away after the next rawhide rebuild.

Comment 4 Jan Kurik 2018-08-14 10:14:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 5 Stan Cox 2019-06-12 21:34:49 UTC
dyninst-testsuite seems to do this on purpose for some binaries using cmake to override any options
set with CFLAGS (-Wl,-z, -pie) and instead uses combinations of its own
testing options including -g, -O0, -O1, -O2, -O3, -fPIC, -m32.

Comment 6 Ben Cotton 2019-10-31 19:07:42 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Ben Cotton 2019-11-27 22:53:09 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.