Bug 1548438 - glibc: Enable annobin annotations
Summary: glibc: Enable annobin annotations
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1552018 1552056 1553705 1554332
Blocks: Fedora28BuildFlags 1561018
TreeView+ depends on / blocked
 
Reported: 2018-02-23 14:16 UTC by Florian Weimer
Modified: 2019-10-30 14:35 UTC (History)
9 users (show)

Fixed In Version: glibc-2.27.9000-8.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1561018 (view as bug list)
Environment:
Last Closed: 2019-10-30 14:35:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-02-23 14:16:07 UTC
We deliberately did not enable annobin for glibc, so that linking against libc_nonshared.a does not produce the annotations in binaries which do not have annobin enabled.

We definitely need to revisit this for rawhide, and perhaps also in Fedora 28 once the first path through build flags injection failures is complete.

Comment 1 Florian Weimer 2018-03-06 13:39:00 UTC
I'm working on this, but ran into an annobin issue (bug 1552018), and now we have relocations in annobin notes (bug 1552056), leading to problems in the glibc elf/ tests.

Comment 2 Florian Weimer 2018-03-08 12:32:31 UTC
Nick has fixed the annobin/binutils issues and x86_64 now builds with annotations.

However, glibc-2.27.9000-8.fc29 does not build on s390x due to IFUNC/NOTE interactions (similar to bug 1552056, but in different code).  I will extract a reproducer and file another binutils bug.

Comment 3 Florian Weimer 2018-03-12 13:06:54 UTC
There's another issue with the -pg tests on ppc64, see bug 1554332.

Comment 4 Florian Weimer 2018-03-12 13:40:15 UTC
The aarch64 IFUNC tests in elf/* were fixed by the patch contained in binutils-2.30-12.fc29 (and s390x stopped crashing), so there is some progress at least.

Comment 5 Jan Kurik 2018-08-14 11:20:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.


Note You need to log in before you can comment on or make changes to this bug.