Bug 1548551 - ledmon: Partial application of Fedora build flags
Summary: ledmon: Partial application of Fedora build flags
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ledmon
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Sekletar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-23 20:19 UTC by Florian Weimer
Modified: 2018-02-26 14:48 UTC (History)
2 users (show)

Fixed In Version: ledmon-0.80-6.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-26 14:48:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-02-23 20:19:24 UTC
/usr/sbin/ledctl and /usr/sbin/ledmon in ledmon-0.80-5.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

There doesn't seem to be any LDFLAGS injection at all.

cc  -lsgutils2 /builddir/build/BUILD/ledmon-0.80/src/_build/ledmon.o /builddir/build/BUILD/ledmon-0.80/src/_build/pidfile.o /builddir/build/BUILD/ledmon-0.80/src/_build/ahci.o /builddir/build/BUILD/ledmon-0.80/src/_build/block.o /builddir/build/BUILD/ledmon-0.80/src/_build/cntrl.o /builddir/build/BUILD/ledmon-0.80/src/_build/enclosure.o /builddir/build/BUILD/ledmon-0.80/src/_build/list.o /builddir/build/BUILD/ledmon-0.80/src/_build/raid.o /builddir/build/BUILD/ledmon-0.80/src/_build/scsi.o /builddir/build/BUILD/ledmon-0.80/src/_build/slave.o /builddir/build/BUILD/ledmon-0.80/src/_build/status.o /builddir/build/BUILD/ledmon-0.80/src/_build/sysfs.o /builddir/build/BUILD/ledmon-0.80/src/_build/smp.o /builddir/build/BUILD/ledmon-0.80/src/_build/dellssd.o /builddir/build/BUILD/ledmon-0.80/src/_build/utils.o /builddir/build/BUILD/ledmon-0.80/src/_build/pci_slot.o /builddir/build/BUILD/ledmon-0.80/src/_build/vmdssd.o -o ledmon

ledmon_cflags.patch probably needs updating to deal with LDFLAGS as well.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.


Note You need to log in before you can comment on or make changes to this bug.