Bug 1548708 - libstemmer: Partial build flags injection
Summary: libstemmer: Partial build flags injection
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libstemmer
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marek Skalický
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-02-24 13:08 UTC by Florian Weimer
Modified: 2018-02-27 18:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-27 18:22:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-02-24 13:08:16 UTC
/usr/lib64/libstemmer.so.0.0.0 in libstemmer-0-8.585svn.fc28.x86_64 has not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config:

cc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -fPIC -Iinclude -shared  -Wl,-soname,libstemmer.so.0 -o libstemmer.so.0.0.0 src_c/stem_ISO_8859_1_danish.o src_c/stem_UTF_8_danish.o src_c/stem_ISO_8859_1_dutch.o src_c/stem_UTF_8_dutch.o src_c/stem_ISO_8859_1_english.o src_c/stem_UTF_8_english.o src_c/stem_ISO_8859_1_finnish.o src_c/stem_UTF_8_finnish.o src_c/stem_ISO_8859_1_french.o src_c/stem_UTF_8_french.o src_c/stem_ISO_8859_1_german.o src_c/stem_UTF_8_german.o src_c/stem_ISO_8859_2_hungarian.o src_c/stem_UTF_8_hungarian.o src_c/stem_ISO_8859_1_italian.o src_c/stem_UTF_8_italian.o src_c/stem_ISO_8859_1_norwegian.o src_c/stem_UTF_8_norwegian.o src_c/stem_ISO_8859_1_porter.o src_c/stem_UTF_8_porter.o src_c/stem_ISO_8859_1_portuguese.o src_c/stem_UTF_8_portuguese.o src_c/stem_ISO_8859_2_romanian.o src_c/stem_UTF_8_romanian.o src_c/stem_KOI8_R_russian.o src_c/stem_UTF_8_russian.o src_c/stem_ISO_8859_1_spanish.o src_c/stem_UTF_8_spanish.o src_c/stem_ISO_8859_1_swedish.o src_c/stem_UTF_8_swedish.o src_c/stem_UTF_8_turkish.o runtime/api.o runtime/utilities.o libstemmer/libstemmer.o

CFLAGS are there, but LDFLAGS are missing.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Marek Skalický 2018-02-27 15:08:56 UTC
Fixed in https://src.fedoraproject.org/rpms/libstemmer/c/b9b745d388ad5bc2b086f9034914322606eea523?branch=master

LDFLAGS="%{build_ldflags}" wasn't working for me in mock "fedora-rawhide-x86_64". The rpm macro seems to be undefined. - Florian, what's wrong?

Comment 2 Florian Weimer 2018-02-27 15:24:24 UTC
(In reply to Marek Skalický from comment #1)
> Fixed in
> https://src.fedoraproject.org/rpms/libstemmer/c/
> b9b745d388ad5bc2b086f9034914322606eea523?branch=master
> 
> LDFLAGS="%{build_ldflags}" wasn't working for me in mock
> "fedora-rawhide-x86_64". The rpm macro seems to be undefined. - Florian,
> what's wrong?

Your mock buildroot is outdated.  Try scrubbing the mock caches.

Comment 3 Florian Weimer 2018-02-27 18:22:00 UTC
libstemmer-0-10.585svn.fc28 looks good.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.