Bug 1548819 - Engine 4.2 does not support host VDSM 4.3
Summary: Engine 4.2 does not support host VDSM 4.3
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ovirt-4.2.2
: ---
Assignee: eraviv
QA Contact: Meni Yakove
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-25 09:50 UTC by Lilach Zitnitski
Modified: 2018-04-29 15:28 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.2.2.4
Clone Of:
Environment:
Last Closed: 2018-03-29 10:58:17 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: ovirt-4.3+
rule-engine: blocker+


Attachments (Terms of Use)
engine log (217.50 KB, application/zip)
2018-02-25 09:51 UTC, Lilach Zitnitski
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 88145 0 master MERGED core: Filter versions in addHostNetworksAndUpdateInterfaces 2020-04-07 07:04:13 UTC
oVirt gerrit 88211 0 master MERGED core: Fix version comparison in VdsBrokerObjectsBuilder 2020-04-07 07:04:13 UTC
oVirt gerrit 88336 0 master MERGED core: Defensive switch-type calculation 2020-04-07 07:04:12 UTC
oVirt gerrit 88535 0 ovirt-engine-4.2 MERGED core: VdsBrokerObjectsBuilder max implementaion 2020-04-07 07:04:12 UTC
oVirt gerrit 88536 0 ovirt-engine-4.2 MERGED core: Filter versions in addHostNetworksAndUpdateInterfaces 2020-04-07 07:04:12 UTC
oVirt gerrit 88537 0 ovirt-engine-4.2 MERGED core: Defensive switch-type calculation 2020-04-07 07:04:13 UTC

Description Lilach Zitnitski 2018-02-25 09:50:26 UTC
Description of problem:
Hosts with vdsm 4.3 version cannot be activated on 4.2 version engine.
The hosts are stuck in activating status.
Also, engine log is full of this error message - 
2018-02-25 03:48:15,876+02 ERROR [org.ovirt.engine.core.vdsbroker.monitoring.HostMonitoring] (EE-ManagedThreadFactory-engineScheduled-Thread-64) [] Unable to RefreshCapabilities beforeFirstRefreshTreatment: IllegalArgumentException: OvsSupported has no value for version:
4.3

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.2-0.1.el7.noarch
vdsm-4.30.0-42.gite0ceee0.el7.centos.x86_64

How reproducible:
100%

Steps to Reproduce:
1. In 4.2 version engine, try to activate host after upgrading it to vdsm 4.3 version

Actual results:
Host is stuck in activating status

Expected results:
engine 4.2 should support 4.3 hosts and the upgraded hosts should be activated successfully in the environment.

Additional info:

Comment 1 Lilach Zitnitski 2018-02-25 09:51:08 UTC
Created attachment 1400539 [details]
engine log

Comment 2 Allon Mureinik 2018-02-25 10:05:21 UTC
Reading through the code, the engine attempts to find the switch type for the maximal cluster version the host supports and doesn't take into consideration the fact that this version may be newer than the maximal cluster version the engine itself supports.

The attached patch should address this.

Comment 3 Nir Soffer 2018-02-28 23:13:38 UTC
Dan, can be get this in 4.2.2? Without this fix we cannot test vdsm master patches.

Being able to run vdsm master with latest engine is basic requirement, it cannot
be broken.

Changing this bug to urgent.

Comment 4 Red Hat Bugzilla Rules Engine 2018-03-01 05:41:21 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 5 Lilach Zitnitski 2018-03-18 11:20:54 UTC
--------------------------------------
Tested with the following code:
----------------------------------------
rhvm-4.2.2.4-0.1.el7.noarch
vdsm-4.30.0-107.git0c94592.el7.centos.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. In 4.2 version engine, try to activate host after upgrading it to vdsm 4.3 version

Actual results:
host is successfully activated

Expected results:

Moving to VERIFIED!

Comment 6 Sandro Bonazzola 2018-03-29 10:58:17 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.