Bug 1548821 - annobin: Annotations and LTO
Summary: annobin: Annotations and LTO
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 29
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1539097
TreeView+ depends on / blocked
Reported: 2018-02-25 10:02 UTC by Florian Weimer
Modified: 2019-11-27 19:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-11-27 19:22:20 UTC
Type: Bug

Attachments (Terms of Use)
build.log (361.97 KB, text/plain)
2018-02-25 10:02 UTC, Florian Weimer
no flags Details

System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1548822 0 unspecified CLOSED libldb: Missing annobin annotations in Python 3 module on x86-64 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1548823 0 unspecified CLOSED libtalloc: Missing annobin annotations in Python 3 module on x86-64 2021-02-22 00:41:40 UTC

Internal Links: 1548822 1548823

Description Florian Weimer 2018-02-25 10:02:37 UTC
Created attachment 1400543 [details]

On x86-64, the Python 3 part of libldb is built with LTO:

20:54:04 runner /usr/bin/gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -fPIC -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -fstack-protector -MD -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none -fno-strict-aliasing -Idefault -I.. -Idefault -I.. -Idefault/include -I../include -Idefault/lib/replace -I../lib/replace -I/usr/local/include -I/usr/include/python3.6m -D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 -DHAVE_CONFIG_H=1 ../pyldb_util.c -c -o default/pyldb_util_9.o


(Full x86-64 build log attached.)

I think this is what causes annobin annotations to be dropped because the plugin isn't active when linking happens:

20:54:10 runner /usr/bin/gcc default/pyldb_util_9.o -o /builddir/build/BUILD/ldb-1.3.1/bin/default/libpyldb-util.cpython-36m-x86-64-linux-gnu.so -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lpthread -Wl,-no-undefined -fstack-protector -shared -Wl,--version-script=/builddir/build/BUILD/ldb-1.3.1/bin/default/pyldb-util.cpython-36m-x86_64-linux-gnu.vscript -Wl,-h,libpyldb-util.cpython-36m-x86-64-linux-gnu.so.1 -Wl,-z,relro -Wl,-z,now -Wl,-z,relro -Wl,-z,now -Ldefault -L/usr/local/lib -Wl,-Bdynamic -lldb -lcrypt -ldl -ltdb -ltevent -ltalloc -lm -lutil -lpython3.6m

I'm not sure what Fedora's official stance on LTO is, but I think we need to figure out how to get annobin annotations even with LTO.

Comment 1 Jan Kurik 2018-08-14 11:08:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 2 Ben Cotton 2019-10-31 20:44:53 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2019-11-27 19:22:20 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.