Created attachment 1400569 [details] engine , vdsm ,libvirt logs Description of problem: Hot unplug on disk looks ok but the following WARNINGS appears on VDSM log. Impact, if any, is not clear. vdsm.log: 2018-02-25 14:26:37,501+0200 WARN (libvirt/events) [virt.vm] (vmId='05361b2e-1ae3-40df-a159-cb4688b303c5') Removed device not found in conf: scsi0-0-0-3 (vm:5995) 2018-02-25 14:26:37,501+0200 WARN (libvirt/events) [virt.vm] (vmId='05361b2e-1ae3-40df-a159-cb4688b303c5') Removed device not found in devices: scsi0-0-0-3 (vm:6005) Libvirt: 2018-02-25 12:26:37.493+0000: 16293: info : qemuMonitorIOProcess:438 : QEMU_MONITOR_IO_PROCESS: mon=0x7fd7280263d0 buf={"id": "libvirt-192", "error": {"class": "DeviceNotFound", "desc": "Device 'drive-scsi0-0-0-3' not found"}} Engine: 2018-02-25 14:26:37,333+02 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.HotUnPlugDiskVDSCommand] (EE-ManagedThreadFactory-engine-Thread-207455) [d4f09054-19ec-44c9-bd36-03bcc8f780c0] START, HotUnPlugDiskVDSCommand(HostName = host_mixed_3, HotPlugDiskVDSParameters:{hostId='7ca55bcf-258c-4fe0-ba34-d7f6dd72c020', vmId='05361b2e-1ae3-40df-a159-cb4688b303c5', diskId='111ac326-4372-46ed-8c92-4192ebeab679', addressMap='[bus=0, controller=0, unit=2, type=drive, target=0]'}), log id: 1499d95b 2018-02-25 14:26:37,681+02 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.HotUnPlugDiskVDSCommand] (EE-ManagedThreadFactory-engine-Thread-207455) [d4f09054-19ec-44c9-bd36-03bcc8f780c0] FINISH, HotUnPlugDiskVDSCommand, log id: 1499d95b 2018-02-25 14:26:37,703+02 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engine-Thread-207455) [d4f09054-19ec-44c9-bd36-03bcc8f780c0] EVENT_ID: USER_HOTUNPLUG_DISK(2,002), VM vm1 disk vm1_Disk3 was unplugged by admin@internal-authz. Version-Release number of selected component (if applicable): vdsm-4.20.18-1.el7ev.x86_64 libvirt-daemon-3.9.0-13.el7.x86_64 ovirt-engine-4.2.2-0.1.el7.noarch qemu-guest-agent-2.8.0-2.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create a VM with OS & wait until it's up & running. 2. Create a disk (disk1) on the VM ( I used NFS / virtio-scsi ) 3. Deactivate (Hot-Unplug) disk1. Actual results: WARNING appears on VDSM : 2018-02-25 14:26:37,501+0200 WARN (libvirt/events) [virt.vm] (vmId='05361b2e-1ae3-40df-a159-cb4688b303c5') Removed device not found in conf: scsi0-0-0-3 (vm:5995) Expected results: No warning should appear. Additional info: Unplug seems to work, impact is not clear.
Hi Milan, What is the meaning of the removed device warning[1]? Do we need it on hot unplug a device? Specifically, for hot unplug disk it seems redundant. [1] WARN (libvirt/events) [virt.vm] (vmId='05361b2e-1ae3-40df-a159-cb4688b303c5') Removed device not found in conf: scsi0-0-0-3 (vm:5995) Thanks!
The warning is in reaction on libvirt event. Hot unplugged devices must be removed from internal Vdsm device lists. Some hot unplug methods wait for device removal a while and if they detect the device removal, they update the internal device structures themselves. Then the device may already be removed when the libvirt event arrives and the warning is logged. In this case the warning is harmless, just confusing. It's a Vdsm problem, reassigned. We prepare general device handling cleanup for 4.3, this should be fixed together with that.
Verified on: ovirt-engine-4.3.0-0.0.master.20181101091940.git61310aa.el7.noarch vdsm-4.30.1-52.git5426c0c.el7.x86_64 Steps: 1. Create a VM with OS & wait until it's up & running. 2. Create a disk (disk1) on the VM ( I used NFS / virtio-scsi ) 3. Deactivate (Hot-Unplug) disk1. 4. Check engine/vdsm logs for warnings and errors. Result: No warning or errors were during the procedure. The disk unplug succeed.
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.