Bug 1549166 - Building the oVirt Engine master branch fails due to pep8, python issues
Summary: Building the oVirt Engine master branch fails due to pep8, python issues
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Build.Make
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ovirt-4.3.0
: ---
Assignee: Sandro Bonazzola
QA Contact: meital avital
URL:
Whiteboard:
Depends On: 1549468
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-26 15:14 UTC by Steven Rosenberg
Modified: 2018-02-27 07:48 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-27 07:48:52 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)
The file contains the full dump of the make console output. (306.36 KB, text/plain)
2018-02-26 15:14 UTC, Steven Rosenberg
no flags Details

Description Steven Rosenberg 2018-02-26 15:14:31 UTC
Created attachment 1400866 [details]
The file contains the full dump of the make console output.

Description of problem:

We found some issues with the oVirt Engine master branch when updating the version via git pull.

Note, the original command for cloning is:

git clone git://gerrit.ovirt.org/ovirt-engine

We then performed the make command:

make clean install-dev PREFIX=~/ovirt_engine_master DEV_BUILD_SCL_POSTGRESQL=1

We receive trickle down errors as follows:

--------------------------------------------------------
+ exit 1
make[1]: *** [validations] Error 1
make[1]: Leaving directory `/home/srosenbe/Documents/git/ovirt-engine'
make: *** [all-dev] Error 2
--------------------------------------------------------

Tracing up the dump file one can see many errors related to the pep8 module:

---------------------------------------------
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py:474:25: E126 continuation line over-indented for hanging indent
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py:481:25: E126 continuation line over-indented for hanging indent
---------------------------------------------

The work around was to remove python-pep8, but this module is used for other packages so our make should support it.

This may be a version issue with the pep8 packages. This is the current yum version:

---------------------------------------------------------

Name        : python-pep8
Arch        : noarch
Version     : 1.4.6
Release     : 3.el7
Size        : 146 k
Repo        : production-rhel-x86_64-workstation-epel-7.4
Summary     : Python style guide checker
License     : MIT
Description : pep8 is a tool to check your Python code against some of the style conventions
            : in PEP 8. It has a plugin architecture, making new checks easy, and its output
            : is parseable, making it easy to jump to an error location in your editor.

----------------------------------------------------------

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. install python-pep8 with yum
2. do a git pull on a previously cloned ovirt-engine master branch (or possibly from a newly cloned ovirt-engine master branch. 
3. Perform a make

Actual results:

We see the errors listed above

Expected results:

The build should succeed.

Additional info:

Please see the attached file for the full dump.

Comment 1 Sandro Bonazzola 2018-02-27 07:24:43 UTC
Checking what happened. CI should have prevented this bug to exist.

Comment 2 Sandro Bonazzola 2018-02-27 07:48:52 UTC
I see you're using 1.4.6-3.el7 while we ship 1.5.7-2.el7 in CentOS Virt SIG.
With 1.5.7 I don't see any issue.
I opened a bug against EPEL (Bug #1549468) for updating the pep8 package they're shipping.
In the meanwhile, please use http://mirror.centos.org/centos/7/virt/x86_64/ovirt-4.2/common/python-pep8-1.5.7-2.el7.noarch.rpm


Note You need to log in before you can comment on or make changes to this bug.