Bug 154958 - wxGTK is not building properly with gcc4
wxGTK is not building properly with gcc4
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: wxGTK (Show other bugs)
rawhide
All Linux
medium Severity high
: ---
: ---
Assigned To: Dams
Fedora Extras Quality Assurance
:
: 155142 (view as bug list)
Depends On:
Blocks: FC4Blocker
  Show dependency treegraph
 
Reported: 2005-04-14 23:13 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-04-22 16:24:18 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
GCC4 patch for wxGTK (9.31 KB, patch)
2005-04-15 14:35 EDT, Ignacio Vazquez-Abrams
no flags Details | Diff
Another patch for gcc4 (445 bytes, patch)
2005-04-16 19:54 EDT, Denis Leroy
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-04-14 23:13:28 EDT
Description of problem:

wxGTK is not being built properly with gcc4. This is causing all packages which
use wxGTK libs to get errors like the following (from comical):

/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `wxwxListStringNode::~wxwxListStringNode()'
/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `wxwxMenuItemListNode::~wxwxMenuItemListNode()'
/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `wxwxMenuItemListNode::~wxwxMenuItemListNode()'
/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `vtable for wxFileProto'
/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `wxwxListStringNode::~wxwxListStringNode()'

This is pretty serious, as its failing other builds which would otherwise succeed.
Comment 1 Ignacio Vazquez-Abrams 2005-04-15 07:04:22 EDT
Hooray for classes created by macros :/

Anyways, I'm working on a patch for this and other warnings against gcc4. The
offending code is a macro in include/list.h.
Comment 2 Ignacio Vazquez-Abrams 2005-04-15 14:35:30 EDT
Created attachment 113243 [details]
GCC4 patch for wxGTK

Give this a spin. It cleans up most warnings.
Comment 3 Tom "spot" Callaway 2005-04-16 10:29:49 EDT
With Ignacio's patch, we are almost there... but we still throw one error:

/usr/lib/gcc/i386-redhat-linux/4.0.0/../../../libwx_gtk2-2.4.so: undefined
reference to `vtable for wxFileProto'

Comment 4 Denis Leroy 2005-04-16 19:54:20 EDT
Created attachment 113274 [details]
Another patch for gcc4

Fixes an incorrect #pragma implementation line. the wxFileProto problem seems
to be ok now.
Comment 5 Tom "spot" Callaway 2005-04-17 00:49:35 EDT
Confirmed, with these two patches, wxGTK2 builds libraries that comical can link
to without error. Mr. Maintainer, please commit these patches, schedule a wxGTK
rebuild, and close this bug. :)

Thanks to Denis and Ignacio.
Comment 6 Dams 2005-04-17 03:57:21 EDT
*** Bug 155142 has been marked as a duplicate of this bug. ***
Comment 7 Warren Togami 2005-04-19 01:30:51 EDT
Anvil did you push this?
Comment 8 Dams 2005-04-20 14:37:41 EDT
Not yet, unfortunately.. i'm unable to connect the cvs. Dunno what i have
broken. I will try to catch sopwith to help me to fix it.. 
Warren, could you commit it please ? Sorry people.
Comment 9 Dams 2005-04-22 16:24:18 EDT
Voila, it's applied in CVS. Thanks people.
It's been requested for rebuild for FE4.

Note You need to log in before you can comment on or make changes to this bug.