Bug 1550250 - [DOCS] "Redeploying Master Certificates Only" recreates "Service Serving Certificates" CA Certificate (service-signer.crt)
Summary: [DOCS] "Redeploying Master Certificates Only" recreates "Service Serving Cert...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Documentation
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Michael Burke
QA Contact: Gaoyun Pei
Vikram Goyal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-28 20:38 UTC by jrmorgan
Modified: 2021-09-09 13:17 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-07 14:48:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description jrmorgan 2018-02-28 20:38:03 UTC
Document URL: 

https://docs.openshift.com/container-platform/3.7/install_config/redeploying_certificates.html#redeploying-master-certificates

Section Number and Name: 

"Installation and Configuration" > "Redeploying Certificates" > "Redeploying Master Certificates Only"

Describe the issue: 

When following "Redeploying Master Certificates Only" documentation [1] there is no indication service-signer.crt and service-signer.key (used for "Service Serving Certificates" [2]) will be purged and regenerated. This is the CA cert responsible for signing any services with annotation "service.alpha.openshift.io/serving-cert-secret-name." It's not obvious this will happen without examining function certificates_to_synchronize [3]. Following execution of redeploy-master-certificates.yml the certificates previously signed by the original service-signer.crt are invalid.

[1]: https://docs.openshift.com/container-platform/3.7/install_config/redeploying_certificates.html#redeploying-master-certificates
[2]: https://docs.openshift.com/container-platform/3.7/dev_guide/secrets.html#service-serving-certificate-secrets
[3]: https://github.com/openshift/openshift-ansible/blob/master/roles/lib_utils/filter_plugins/openshift_master.py#L495-L496

Suggestions for improvement: 

Until redeploy of service-signer.crt and service-signer.key (used for "Service Serving Certificates" [2]) is split-off from redeploy-master-certificates.yml there should be a warning or informational disclaimer noting "Service Signing Certificates" will need to be regenerated after playbook execution (by deleting existing secrets containing service serving certificates or removing/re-adding annotations to appropriate services).

Additional information: 

Due to recreation of service-signer.crt & service-signer.key implicit trusts required for proper routing will break. Router pods will stop trusting old certificates (signed by the original service-signer.crt) still referenced in running pod secrets and as a result HAProxy may mark the backends as down due to "Layer6 invalid response, info: SSL handshake failure"

Comment 2 Michael Burke 2018-03-22 20:33:55 UTC
@j.r. -- PTAL

https://github.com/openshift/openshift-docs/pull/8373

It doesn't appear from the BZ or the https://access.redhat.com/support/cases/02041417 that we need to add the Additional Information from the description?

Comment 3 jrmorgan 2018-04-03 00:53:02 UTC
(In reply to Michael Burke from comment #2)
> @j.r. -- PTAL
> 
> https://github.com/openshift/openshift-docs/pull/8373
> 
> It doesn't appear from the BZ or the
> https://access.redhat.com/support/cases/02041417 that we need to add the
> Additional Information from the description?

Correct, Michael. LGTM - the [Important] note is perfect. Thank you!

Comment 6 Gaoyun Pei 2018-04-12 06:52:20 UTC
Add comments in the PR


Note You need to log in before you can comment on or make changes to this bug.