Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-gravatar.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-gravatar-0.4.2-2.fc27.src.rpm Description: This is small and simple integration gravatar into flask. Fedora Account System Username: itamarjp
Looks good, please go ahead.
Approved.
Hi Devrim. Was this a formal review? If so, you should change the Fedora-review flag to '+' (if you are a fedora packager).
Hi Itamar, Here is my review: 1) Check this warnings on rpmlint: python-flask-gravatar.src:23: W: unversioned-explicit-provides python-%{pkg_name} python-flask-gravatar.src:33: W: unversioned-explicit-provides python-%{pkg_name} - You forgot to include the python2 package name on the first %file section. - Remove the Provides: python-... from both python2 and python3 packages. 2) See this fedora-review warnings: Note: No known owner of /usr/lib/python3.6/site- packages/flask_gravatar, /usr/lib/python2.7/site- packages/flask_gravatar, /usr/lib/python3.6/site- packages/flask_gravatar/__pycache__ - On your %file sections, you must also own the package root directory "flask_gravatar". - For the python3 subpackage, you must also own the flask_gravatar/__pycache__ directory 3) Why are you including PKG-INFO in %doc? You could include the CHANGES, RELEASE-NOTES and AUTHORS here instead :) 4) Version 0.5 is already tagged in github 5) The Group: tag is not used in Fedora, you can safely remove it 6) The Summary: tags on both subpackages are wrong - They describe a different package. 7) You could use github and some macros for Source0 so you won't have to keep editing it every time a new release is out. It will also help release-monitoring with scratch builds. Here is a complete fedora-review report: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.6/site- packages/flask_gravatar, /usr/lib/python2.7/site- packages/flask_gravatar, /usr/lib/python3.6/site- packages/flask_gravatar/__pycache__ [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/flask_gravatar, /usr/lib/python3.6/site- packages/flask_gravatar, /usr/lib/python3.6/site- packages/flask_gravatar/__pycache__ [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-flask-gravatar-0.4.2-2.fc28.noarch.rpm python3-flask-gravatar-0.4.2-2.fc28.noarch.rpm python-flask-gravatar-0.4.2-2.fc28.src.rpm python-flask-gravatar.src:23: W: unversioned-explicit-provides python-%{pkg_name} python-flask-gravatar.src:33: W: unversioned-explicit-provides python-%{pkg_name} 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python-flask-gravatar.noarch: W: invalid-url URL: http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or service not known> python3-flask-gravatar.noarch: W: invalid-url URL: http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python-flask-gravatar (rpmlib, GLIBC filtered): python(abi) python3-flask-gravatar (rpmlib, GLIBC filtered): python(abi) python3-flask Provides -------- python-flask-gravatar: python-flask-gravatar python2.7dist(flask-gravatar) python2dist(flask-gravatar) python3-flask-gravatar: python-flask-gravatar python3-flask-gravatar python3.6dist(flask-gravatar) python3dist(flask-gravatar) Source checksums ---------------- https://pypi.python.org/packages/b3/7c/162f5b98b88d2088a1a451ae4a354c725c700246ae69cb8cc26175508e65/Flask-Gravatar-0.4.2.tar.gz : CHECKSUM(SHA256) this package : 318dd427a21245ace37027246193daad3492e08fcf9999d2fe9addae4c8aacd3 CHECKSUM(SHA256) upstream package : 318dd427a21245ace37027246193daad3492e08fcf9999d2fe9addae4c8aacd3
http://ispbrasil.com.br/review/python-flask-gravatar.spec http://ispbrasil.com.br/review/python-flask-gravatar-0.5.0-1.fc27.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=25400223
Hi Itamar, There are still some changes pending: 1) Remove the Provides on the unversioned python packages, those go against Python packaging guidelines. 2) The pypi URL does not contain the sources for version 0.5.0, you want to get that from github [1] (you can substitute the tag after 'archive for %{version} to make your life easier in the future). Could not download Source0: https://pypi.python.org/packages/b3/7c/162f5b98b88d2088a1a451ae4a354c725c700246ae69cb8cc26175508e65 /Flask-Gravatar-0.5.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags 3) In lines 54 and 62, under the %files sections, you are listing a directory. Those line mean "package this directory AND everything under it". But then you list specific files under those directories again. This leads to the following warning: Note: BUILDSTDERR: warning: File listed twice: /usr/lib/python2.7/site- packages/flask_gravatar/__init__.py See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles To solve the issue, append "%dir" to the beginning of lines 54 and 62. 4) Remove the "." from the end of the Summary. [1] https://github.com/zzzsochi/Flask-Gravatar/archive/v0.5.0/Flask-Gravatar-0.5.0.tar.gz Here is the rpmlint output: Rpmlint ------- Checking: python2-flask-gravatar-0.5.0-1.fc28.noarch.rpm python3-flask-gravatar-0.5.0-1.fc28.noarch.rpm python-flask-gravatar-0.5.0-1.fc28.src.rpm python2-flask-gravatar.noarch: E: useless-provides python-flask-gravatar python2-flask-gravatar.noarch: W: self-obsoletion python-flask-gravatar < 0.5.0-1.fc28 obsoletes python-flask-gravatar python-flask-gravatar.src: W: summary-ended-with-dot C Small extension for Flask to make usage of Gravatar service easy. python-flask-gravatar.src:22: W: unversioned-explicit-provides python-%{pkg_name} python-flask-gravatar.src:31: W: unversioned-explicit-provides python-%{pkg_name} python-flask-gravatar.src: W: invalid-url Source0: https://pypi.python.org/packages/b3/7c/162f5b98b88d2088a1a451ae4a354c725c700246ae69cb8cc26175508e65/Flask-Gravatar-0.5.0.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 1 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- python2-flask-gravatar.noarch: W: invalid-url URL: http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or service not known> python2-flask-gravatar.noarch: E: useless-provides python-flask-gravatar python2-flask-gravatar.noarch: W: self-obsoletion python-flask-gravatar < 0.5.0-1.fc28 obsoletes python-flask-gravatar python3-flask-gravatar.noarch: W: invalid-url URL: http://github.com/zzzsochi/Flask-Gravatar/ <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 1 errors, 3 warnings.
fixed here https://itamarjp.fedorapeople.org/review/python-flask-gravatar.spec
/usr/lib/python3.6/site-packages/flask_gravatar/__pycache__ Has no owner. You should do the same %dir procedure for the __pycache__ directory in the python3 package %files section. Please, upload both the spec and the srpm file so fedora-review can parse the review request correctly.
done https://itamarjp.fedorapeople.org/review/python-flask-gravatar.spec https://itamarjp.fedorapeople.org/review/python-flask-gravatar-0.5.0-1.fc27.src.rpm
- All rpmlint issues were properly addressed. - The directories ownling issues were addressed - python egg files in %doc were removed - latest version packaged and Sources links fixed -Group tag removed - Summary issues addressed - Unversioned Provides removed Package looks good to me. Approved
$ fedpkg --module-name python-flask-gravatar request-repo 1550319 https://pagure.io/releng/fedora-scm-requests/issue/4814
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-gravatar
thank you . https://koji.fedoraproject.org/koji/packageinfo?packageID=26433