Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid-0.2-1.fc27.src.rpm Description: Flask Simple user session protection Fedora Account System Username:itamarjp
Looks good, but I'm seeing this in pgadmin4 requirements.txt: Flask-Paranoid==0.1.0 What about starting with 0.1.0, and then updating to 0.2, when I get approval from pgadmin4 team?
- The URL returns 404 https://github.com/mattupstate/flask-paranoid - Run the tests provided by upstream and build the docs with Sphinx - Not good: Requires: python2-flask %{?python_provide:%python_provide python-%{pkg_name}} - Not needed either in both subpackages Provides: python-%{pkg_name} - Not needed: Group: - No BuildRequires: python3-flask ??
(In reply to Robert-André Mauchin from comment #2) there are no docs and the tests are failing, I will report the bug about the tests to upstream.
I verified and there's no tests when the pypi source are used, https://pypi.python.org/pypi/Flask-Paranoid
Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid-0.2-1.fc27.src.rpm
(In reply to Devrim Gündüz from comment #1) > Looks good, but I'm seeing this in pgadmin4 requirements.txt: > > Flask-Paranoid==0.1.0 > > What about starting with 0.1.0, and then updating to 0.2, when I get > approval from pgadmin4 team? Fedora only accepts the latest version for new packages.
- Remove the dot at the end of the summary: python-flask-paranoid.src: W: summary-ended-with-dot C Flask Simple user session protection. - Version in changelog is wrong: * Thu Mar 01 2018 Itamar Reis Peixoto <itamar.br> - 0.2.0-1 - Be more specific in %files: %files -n python2-%{pkg_name} %{python2_sitelib}/flask_paranoid %{python2_sitelib}/Flask_Paranoid-%{version}-py?.?.egg-info %files -n python%{python3_pkgversion}-%{pkg_name} %{python3_sitelib}/flask_paranoid %{python2_sitelib}/Flask_Paranoid-%{version}-py?.?.egg-info Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-flask- paranoid/review-python-flask-paranoid/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -flask-paranoid , python3-flask-paranoid [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-flask-paranoid-0.2.0-1.fc29.noarch.rpm python3-flask-paranoid-0.2.0-1.fc29.noarch.rpm python-flask-paranoid-0.2.0-1.fc29.src.rpm python2-flask-paranoid.noarch: W: invalid-url URL: http://github.com/mattupstate/flask-paranoid/ HTTP Error 404: Not Found python2-flask-paranoid.noarch: W: no-documentation python3-flask-paranoid.noarch: W: invalid-url URL: http://github.com/mattupstate/flask-paranoid/ HTTP Error 404: Not Found python3-flask-paranoid.noarch: W: no-documentation python-flask-paranoid.src: W: summary-ended-with-dot C Flask Simple user session protection. python-flask-paranoid.src: W: invalid-url URL: http://github.com/mattupstate/flask-paranoid/ HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 6 warnings.
Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-paranoid-0.2.0-2.fc28.src.rpm
Package approved.
$ fedpkg --module-name python-flask-paranoid request-repo 1550330 https://pagure.io/releng/fedora-scm-requests/issue/5943
$ fedpkg --module-name python-flask-paranoid request-branch f27 https://pagure.io/releng/fedora-scm-requests/issue/5944 $ fedpkg --module-name python-flask-paranoid request-branch f28 https://pagure.io/releng/fedora-scm-requests/issue/5945
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-paranoid
python-flask-paranoid-0.2.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc266e6531
python-flask-paranoid-0.2.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-406d663d41
python-flask-paranoid-0.2.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
python-flask-paranoid-0.2.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.