Bug 1550554 - splix: Partial Fedora build flags injection
Summary: splix: Partial Fedora build flags injection
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: splix
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-03-01 12:51 UTC by Florian Weimer
Modified: 2018-03-02 15:38 UTC (History)
3 users (show)

Fixed In Version: splix-2.0.1-0.36.20130902svn.fc29
Clone Of:
Environment:
Last Closed: 2018-03-02 15:38:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-03-01 12:51:38 UTC
/usr/lib/cups/filter/rastertoqpdl and /usr/lib/cups/filter/pstoqpdl in splix-2.0.1-0.35.20130902svn.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config:

g++ -o optimized/rastertoqpdl optimized/src/rastertoqpdl.o optimized/src/request.o optimized/src/printer.o optimized/src/qpdl.o optimized/src/document.o optimized/src/core.o optimized/src/compress.o optimized/src/algorithm.o optimized/src/ppdfile.o optimized/src/page.o optimized/src/colors.o optimized/src/band.o optimized/src/bandplane.o optimized/src/cache.o optimized/src/rendering.o optimized/src/semaphore.o optimized/src/algo0x0d.o optimized/src/algo0x0e.o optimized/src/algo0x11.o optimized/src/algo0x13.o optimized/src/algo0x15.o  `cups-config --ldflags` -L/opt/local/lib \
	`cups-config --libs` -lcupsimage -lpthread -ljbig85

g++ -o optimized/pstoqpdl optimized/src/pstoqpdl.o optimized/src/ppdfile.o  `cups-config --ldflags` \
	`cups-config --libs` -lcupsimage -lpthread

There is no LDFLAGS injection at all.  cups-config isn't very helpful:

# cups-config --ldflags

# cups-config --libs
-lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lpthread -lm -lcrypt

(Hard-coding the build flags into cups-config wouldn't be advisable anyway.)

Comment 1 Zdenek Dohnal 2018-03-02 15:38:27 UTC
Built for rawhide and f28.


Note You need to log in before you can comment on or make changes to this bug.