Bug 1550564 - GYP requires ambiguous python version while building nodejs
Summary: GYP requires ambiguous python version while building nodejs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nodejs
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: NodeJS Packaging SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1537244
TreeView+ depends on / blocked
 
Reported: 2018-03-01 13:22 UTC by Stephen Gallagher
Modified: 2018-08-08 16:44 UTC (History)
11 users (show)

Fixed In Version: nodejs-10-20180720171652.9c690d0e
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-08 16:44:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Stephen Gallagher 2018-03-01 13:22:44 UTC
Description of problem:
+ export 'CXXFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -g   -D_LARGEFILE_SOURCE   -D_FILE_OFFSET_BITS=64   -DZLIB_CONST   -fno-delete-null-pointer-checks '
+ CXXFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -g   -D_LARGEFILE_SOURCE   -D_FILE_OFFSET_BITS=64   -DZLIB_CONST   -fno-delete-null-pointer-checks '
+ ./configure --prefix=/usr --shared-openssl --shared-zlib --shared-libuv --shared-http-parser --shared-nghttp2 --with-dtrace --with-intl=system-icu --debug-http2 --debug-nghttp2 --openssl-use-def-ca-store
DEPRECATION WARNING: python2 invoked with /usr/bin/python.
    Use /usr/bin/python3 or /usr/bin/python2
    /usr/bin/python will be removed or switched to Python 3 in the future.
    If you cannot make the switch now, please follow instructions at https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out
gyp: Call to 'python -c "import sys; print sys.byteorder"' returned exit status 0 while in /builddir/build/BUILD/node-v8.9.4/deps/v8/src/v8.gyp. while loading dependencies of /builddir/build/BUILD/node-v8.9.4/node.gyp while trying to load /builddir/build/BUILD/node-v8.9.4/node.gyp

Current build in Fedora is using the quick opt-out, but we will need to address this at some point. The deprecation warning causes the build to fail.


Version-Release number of selected component (if applicable):
nodejs-9.7.0-1.fc28

How reproducible:
Every time

Steps to Reproduce:
1. Build nodejs without PYTHON_DISALLOW_AMBIGUOUS_VERSION=0

Actual results:
Build fails with above error

Expected results:
Build should succeed.

Additional info:

Comment 1 Tom Hughes 2018-03-01 13:31:36 UTC
I think you have misunderstood - that's not gyp itself rather it is a line in the gyp file shelling out to python.

Yes the fact that python returns 1 rather than the original exit code when the warning is issued is annoying...

Comment 2 Tom Hughes 2018-03-01 13:55:10 UTC
Actually it does exit zero but I think gyp treats a shell out as failing if it prints anything to stderr.

Comment 3 Miro Hrončok 2018-03-01 14:01:58 UTC
that gyp file is part of nedejs sources?

Comment 4 Tom Hughes 2018-03-01 14:05:06 UTC
Well the v8 sources that are bundled in the nodejs sources, yes.

Comment 5 Miro Hrončok 2018-03-01 14:44:28 UTC
I suggest you patch or sed it to python2 and propose that to upstream v8 or nodejs.

Comment 6 Fedora Update System 2018-05-29 18:38:13 UTC
nodejs-10-20180529134034.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-1267343a9e

Comment 7 Fedora Update System 2018-05-30 14:54:09 UTC
nodejs-10-20180529134034.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-1267343a9e

Comment 8 Fedora Update System 2018-05-30 18:34:20 UTC
nodejs-10-20180530154512.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-1267343a9e

Comment 9 Fedora Update System 2018-05-31 12:37:40 UTC
nodejs-10-20180530154512.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-1267343a9e

Comment 10 Miro Hrončok 2018-06-01 03:29:36 UTC
This was filled against non-modular nodejs.

Comment 11 Fedora Update System 2018-06-07 18:16:56 UTC
nodejs-10-20180607142235.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-ba47204e67

Comment 12 Miro Hrončok 2018-06-08 11:11:01 UTC
This was filled against non-modular nodejs.

Comment 13 Fedora Update System 2018-06-08 13:17:50 UTC
nodejs-10-20180607142235.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-ba47204e67

Comment 14 Miro Hrončok 2018-06-08 13:36:46 UTC
This was filled against non-modular nodejs.

Comment 15 Fedora Update System 2018-06-15 17:43:46 UTC
nodejs-10-20180614125709.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-ba47204e67

Comment 16 Fedora Update System 2018-06-16 19:36:50 UTC
nodejs-10-20180614125709.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-ba47204e67

Comment 17 Fedora Update System 2018-06-25 12:49:34 UTC
nodejs-10-20180622010510.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-aab3ad1ed2

Comment 18 Fedora Update System 2018-06-26 17:52:14 UTC
nodejs-10-20180622010510.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-aab3ad1ed2

Comment 19 Fedora Update System 2018-07-30 11:40:34 UTC
nodejs-10-20180720171652.9c690d0e has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-4058b2f0fb

Comment 20 Fedora Update System 2018-07-30 15:15:10 UTC
nodejs-10-20180720171652.9c690d0e has been pushed to the Fedora 28 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2018-4058b2f0fb

Comment 21 Fedora Update System 2018-08-08 16:44:29 UTC
nodejs-10-20180720171652.9c690d0e has been pushed to the Fedora 28 Modular stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.