Bug 1550846 - nvmetcli not fully Python3 compatible
Summary: nvmetcli not fully Python3 compatible
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: nvmetcli
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Maurizio Lombardi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-02 07:43 UTC by Sitsofe Wheeler
Modified: 2021-02-26 23:54 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 23:11:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Sitsofe Wheeler 2018-03-02 07:43:10 UTC
Description of problem:
Trying to run 
nvmetcli restore loop.json
results in a python backtrace.

Version-Release number of selected component (if applicable):
nvmetcli-0.4-1.fc26.noarch

How reproducible:
Reproducible every time.

Steps to Reproduce:
1. cd /tmp/
2. curl -OL http://git.infradead.org/users/hch/nvmetcli.git/blob_plain/HEAD:/examples/loop.json
3. nvmetcli restore loop.json 

Actual results:
  File "/usr/sbin/nvmetcli", line 617, in <module>
    main()
  File "/usr/sbin/nvmetcli", line 600, in main
    funcs[sys.argv[1]](savefile)
  File "/usr/sbin/nvmetcli", line 563, in restore
    errors = nvme.Root().restore_from_file(from_file)
  File "/usr/lib/python3.6/site-packages/nvmet/nvme.py", line 381, in restore_from_file
    abort_on_error=abort_on_error)
  File "/usr/lib/python3.6/site-packages/nvmet/nvme.py", line 355, in restore
    Subsystem.setup(t, err_func)
  File "/usr/lib/python3.6/site-packages/nvmet/nvme.py", line 496, in setup
    Namespace.setup(s, ns, err_func)
  File "/usr/lib/python3.6/site-packages/nvmet/nvme.py", line 590, in setup
    ns._setup_attrs(n, err_func)
  File "/usr/lib/python3.6/site-packages/nvmet/nvme.py", line 222, in _setup_attrs
    for name, value in attr_dict.get(group, {}).iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'

Expected results:
Not an internal syntax error.

Additional info:
To be Python3 compatible line 222 of /usr/lib/python3.6/site-packages/nvmet/nvme.py will need iteritems() changing to items() .

Comment 1 Fedora End Of Life 2018-05-03 07:56:27 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 2 Sitsofe Wheeler 2018-05-04 08:27:39 UTC
Judging from https://src.fedoraproject.org/rpms/nvmetcli/commits/master this one is still here in Fedora 28 and rawhide so I'm updating the version.

Comment 3 Jan Kurik 2018-08-14 10:13:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 4 Ben Cotton 2019-10-31 18:58:25 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-11-27 23:11:41 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Tomáš Bžatek 2021-02-18 13:51:26 UTC
This should be finally fixed in:
  nvmetcli-0.7-1.fc33
  nvmetcli-0.7-1.fc34
  nvmetcli-0.7-1.fc35

Comment 7 Fedora Update System 2021-02-18 13:53:18 UTC
FEDORA-2021-726a5c34da has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-726a5c34da

Comment 8 Fedora Update System 2021-02-19 02:04:14 UTC
FEDORA-2021-726a5c34da has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-726a5c34da`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-726a5c34da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-02-26 23:54:40 UTC
FEDORA-2021-726a5c34da has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.