Bug 1552449 - [UI] - Adjust VM's vNIC panel to the exact size of the host's NIC panel and align vNIC's icons to the center
Summary: [UI] - Adjust VM's vNIC panel to the exact size of the host's NIC panel and a...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.2.2
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.2.4
: ---
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-07 07:51 UTC by Michael Burman
Modified: 2018-06-26 08:37 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.2.4.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 08:37:58 UTC
oVirt Team: Network
rule-engine: ovirt-4.2+
ylavi: exception+


Attachments (Terms of Use)
current VM vNIC panel (57.03 KB, image/png)
2018-03-07 07:51 UTC, Michael Burman
no flags Details
screenshots (33.88 KB, application/x-gzip)
2018-05-27 08:16 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 90259 0 master MERGED webadmin: Match VM interfaces design with Host interfaces design 2018-05-07 11:52:41 UTC
oVirt gerrit 90975 0 ovirt-engine-4.2 MERGED webadmin: Match VM interfaces design with Host interfaces design 2018-05-09 08:47:14 UTC
oVirt gerrit 91722 0 master MERGED webadmin: Fix the too narrow VM interface problem 2018-05-29 14:44:20 UTC
oVirt gerrit 91747 0 ovirt-engine-4.2 MERGED webadmin: Fix the too narrow VM interface problem 2018-05-30 07:30:36 UTC

Description Michael Burman 2018-03-07 07:51:17 UTC
Created attachment 1405172 [details]
current VM vNIC panel

Description of problem:
[UI] - Adjust VM's vNIC panel to the exact size of the host's NIC panel and align vNIC's icons to the center.

I would like to request a final adjustment(promise) for the vNIC's panel.
It should be at the exact size of the current NIC host panel, currently it is to wide and when you have multiple vNIC's on the VM it is looks bad. There is no reason for this panels to be so wide, specially when they have sub tabs. 

- Another thing, the VM's vNIC icons(plug, link state and the NIC's icon it self) must be aligned to the center, currently it look weird. 
The size of the icons is great.

Version-Release number of selected component (if applicable):
4.2.2.2-0.1.el7

How reproducible:
100

See also - relevant bugs for this whole NIC panel adjustments that were requested and done(the bond still missing adjustment) for VM's and hosts -
BZ 1483846 (information adjustment on the vNIC's panel)
BZ 1538642 (adjust bond on host NIC panel)
BZ 1523286 (already done by ux team and it's look great!)

Comment 1 Dan Kenigsberg 2018-03-07 08:32:38 UTC
I suppose we can narrow down the height of each vnic panel in 4.2.z, can we?

Comment 2 Michael Burman 2018-05-27 08:14:29 UTC
Ales, 
the VM's vNIC panel now is narrower than the host's NIC, not sure if it's by propose? in my opinion it's to much narrow now, looks like it got cut in the bottom.

Comment 3 Michael Burman 2018-05-27 08:16:39 UTC
Created attachment 1442207 [details]
screenshots

Comment 4 Michael Burman 2018-05-27 08:18:01 UTC
Btw, the icons are broken as well, see BZ 1582824

Comment 5 Greg Sheremeta 2018-05-29 14:42:45 UTC
> I would like to request a final adjustment(promise)

Your improvements have been extremely valuable. Please don't be shy!

Comment 7 Michael Burman 2018-06-03 12:40:29 UTC
Verified on - 4.2.4.1-0.1.el7

Comment 8 Sandro Bonazzola 2018-06-26 08:37:58 UTC
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.