Red Hat Bugzilla – Bug 1552628
CVE-2018-1000120 curl: FTP path trickery leads to NIL byte out of bounds write
Last modified: 2018-10-30 03:43:17 EDT
It was found that curl can be fooled into writing a zero byte out of bounds. This bug can trigger when curl is told to work on an FTP URL, with the setting to only issue a single CWD command (`--ftp-method singlecwd` or the libcurl alternative `CURLOPT_FTP_FILEMETHOD`). curl then URL-decodes the given path, calls strlen() on the result and deducts the length of the file name part to find the end of the directory within the buffer. It then writes a zero byte on that index, in a buffer allocated on the heap. If the directory part of the URL contains a "%00" sequence, the directory length might end up shorter than the file name path, making the calculation `size_t index = directory_len - filepart_len` end up with a huge index variable for where the zero byte gets stored: `heap_buffer[index] = 0`. On several architectures that huge index will wrap and work as a negative value, thus overwriting memory *before* the intended heap buffer. By using different file part lengths and putting %00 in different places in the URL, an attacker that can control what paths a curl-using application uses can write that zero byte on different indexes.
Acknowledgments: Name: the Curl project Upstream: Duy Phan Thanh
Created attachment 1405333 [details] upstream patch
Mitigation: Preventing application from using non-default CURLOPT_FTP_FILEMETHOD will avoid triggering the vulnerable code.
External References: https://curl.haxx.se/docs/adv_2018-9cd6.html
Created mingw-curl tracking bugs for this issue: Affects: fedora-all [bug 1555207] Created curl tracking bugs for this issue: Affects: fedora-all [bug 1555209] Created mingw-curl tracking bugs for this issue: Affects: epel-7 [bug 1555208]
Upstream commit: FTP: reject path components with control codes https://github.com/curl/curl/commit/535432c0ad
This issue has been addressed in the following products: Red Hat Enterprise Linux 7 Via RHSA-2018:3157 https://access.redhat.com/errata/RHSA-2018:3157