Bug 1552661 - s390utils: Incomplete Fedora build flags injection
Summary: s390utils: Incomplete Fedora build flags injection
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: s390utils
Version: 28
Hardware: s390x
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-03-07 13:41 UTC by Florian Weimer
Modified: 2018-03-30 12:51 UTC (History)
2 users (show)

Fixed In Version: s390utils-2.3.0-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-30 12:51:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-03-07 13:41:17 UTC
Various files in s390utils-base-2:2.3.0-1.fc28.s390x and related packages have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config, for example:

gcc -rdynamic qetharp.o   -o qetharp

There is no LDFLAGS injection at all.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Dan Horák 2018-03-12 10:10:04 UTC
Florian, do you have a complete list of binaries linked without the system-wide LDFLAGS?

Comment 2 Florian Weimer 2018-03-12 10:21:24 UTC
Based on the Fedora 28 package, I have:

         name          |             file             | aslr | bind_now 
-----------------------+------------------------------+------+----------
 s390utils-base        | /usr/bin/dump2tar            | f    | f
 s390utils-base        | /usr/bin/vmconvert           | f    | f
 s390utils-base        | /usr/bin/zkey                | f    | f
 s390utils-base        | /usr/lib64/src_vipa.so       | t    | f
 s390utils-base        | /usr/sbin/chchp              | f    | f
 s390utils-base        | /usr/sbin/chreipl            | f    | f
 s390utils-base        | /usr/sbin/chzcrypt           | f    | f
 s390utils-base        | /usr/sbin/chzdev             | f    | f
 s390utils-base        | /usr/sbin/dasdfmt            | f    | f
 s390utils-base        | /usr/sbin/dasdinfo           | f    | f
 s390utils-base        | /usr/sbin/dasdview           | f    | f
 s390utils-base        | /usr/sbin/fdasd              | f    | f
 s390utils-base        | /usr/sbin/hyptop             | f    | f
 s390utils-base        | /usr/sbin/lschp              | f    | f
 s390utils-base        | /usr/sbin/lscss              | f    | f
 s390utils-base        | /usr/sbin/lsqeth             | f    | f
 s390utils-base        | /usr/sbin/lsscm              | f    | f
 s390utils-base        | /usr/sbin/lszcrypt           | f    | f
 s390utils-base        | /usr/sbin/lszdev             | f    | f
 s390utils-base        | /usr/sbin/qetharp            | f    | f
 s390utils-base        | /usr/sbin/qethqoat           | f    | f
 s390utils-base        | /usr/sbin/tape390_crypt      | f    | f
 s390utils-base        | /usr/sbin/tape390_display    | f    | f
 s390utils-base        | /usr/sbin/ttyrun             | f    | f
 s390utils-base        | /usr/sbin/tunedasd           | f    | f
 s390utils-base        | /usr/sbin/vmcp               | f    | f
 s390utils-base        | /usr/sbin/vmur               | f    | f
 s390utils-base        | /usr/sbin/xcec-bridge        | f    | f
 s390utils-base        | /usr/sbin/zgetdump           | f    | f
 s390utils-base        | /usr/sbin/zipl               | f    | f
 s390utils-cmsfs       | /usr/sbin/cmsfscat           | f    | f
 s390utils-cmsfs       | /usr/sbin/cmsfsck            | f    | f
 s390utils-cmsfs       | /usr/sbin/cmsfscp            | f    | f
 s390utils-cmsfs       | /usr/sbin/cmsfslst           | f    | f
 s390utils-cmsfs       | /usr/sbin/cmsfsvol           | f    | f
 s390utils-cmsfs-fuse  | /usr/bin/cmsfs-fuse          | f    | f
 s390utils-cpacfstatsd | /usr/bin/cpacfstats          | f    | f
 s390utils-cpacfstatsd | /usr/sbin/cpacfstatsd        | f    | f
 s390utils-cpuplugd    | /usr/sbin/cpuplugd           | f    | f
 s390utils-hmcdrvfs    | /usr/bin/hmcdrvfs            | f    | f
 s390utils-iucvterm    | /usr/bin/iucvconn            | f    | f
 s390utils-iucvterm    | /usr/bin/iucvtty             | f    | f
 s390utils-mon_statd   | /usr/sbin/mon_fsstatd        | f    | f
 s390utils-mon_statd   | /usr/sbin/mon_procd          | f    | f
 s390utils-zdsfs       | /usr/bin/zdsfs               | f    | f
 s390utils-ziomon      | /usr/sbin/ziomon_mgr         | f    | f
 s390utils-ziomon      | /usr/sbin/ziomon_util        | f    | f
 s390utils-ziomon      | /usr/sbin/ziomon_zfcpdd      | f    | f
 s390utils-ziomon      | /usr/sbin/ziorep_traffic     | f    | f
 s390utils-ziomon      | /usr/sbin/ziorep_utilization | f    | f
(50 rows)

CFLAGS injection appears to be basically working, but LDFLAGS are not passed to the linker invocation.

Comment 3 Fedora Update System 2018-03-12 15:20:57 UTC
s390utils-2.3.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1556fc1df9

Comment 4 Fedora Update System 2018-03-13 15:08:32 UTC
s390utils-2.3.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1556fc1df9

Comment 5 Fedora Update System 2018-03-30 12:51:38 UTC
s390utils-2.3.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.