Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1552929

Summary: Spurious includepkgs lines present after installation in all sections of ovirt-4.2-dependencies.repo
Product: [oVirt] ovirt-node Reporter: Giuseppe Ragusa <giuseppe.ragusa>
Component: Installation & UpdateAssignee: Ryan Barry <rbarry>
Status: CLOSED NOTABUG QA Contact: cshao <cshao>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.2CC: bugs, cshao, huzhao, jiaczhan, qiyuan, weiwang, ycui, yzhao
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-07 23:55:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .repo file as found after installation from latest 4.2.1 NGN ISO none

Description Giuseppe Ragusa 2018-03-07 23:08:54 UTC
Created attachment 1405639 [details]
The .repo file as found after installation from latest 4.2.1 NGN ISO

Description of problem:

After installation from latest 4.2.1 ISO each and every repo section in /etc/yum.repos.d/ovirt-4.2-dependencies.repo contains the following line:

includepkgs=ovirt-node-ng-image-update ovirt-node-ng-image ovirt-engine-appliance

The only place where this line should be present is IMO in /etc/yum.repos.d/ovirt-4.2.repo

Please note that the same bug is present after installation with latest 4.1.9 ISO

Version-Release number of selected component (if applicable):

ovirt-node-ng-installer-ovirt-4.2-2018030606.iso
ovirt-node-ng-installer-ovirt-4.1-2018012707.iso

How reproducible:

Simply install interactively (behaviour present also when installing with a kickstart).

Steps to Reproduce:
1. Perform installation
2. Reboot
3. Check /etc/yum.repos.d/ovirt-4.2-dependencies.repo

Actual results:

Each and every section contains (after the "name=" line):

includepkgs=ovirt-node-ng-image-update ovirt-node-ng-image ovirt-engine-appliance


Expected results:

No spurious includepkgs line referring to packages provided from a different repo.

Additional info:

As stated above, the same behaviour is present when installing from latest 4.1.9 ISO.

Comment 1 Ryan Barry 2018-03-07 23:55:21 UTC
This is not a bug.

These lines are included in all repo files so, in case they are enabled, packages must be whitelisted.

ovirt-node-ng is intended to be updated as a single system image, and we don't want to catch updates from CentOS-Updates, EPEL, or other repositories.

Comment 2 Giuseppe Ragusa 2018-03-12 22:05:59 UTC
I absolutely understand the reasoning.

Just a note: why not simply disable all repositories besides ovirt-4.2, then in that repo only allow (by means of the aforementioned includepkgs line) the ovirt-node and engine-appliance packages?

Wouldn't that be a more "clean"/self-documenting/obvious solution?

It's not like you need a "defense in depth" from the local system administrator ;-)
She/he must be informed of the upgrade procedures anyway.

I ask only because I use a kickstart to customize the NGN image in the %post phase (before finalizing imgbased) by installing further packages from base and the current setup forces me to manually and exactly track and list all dependencies.