Description of problem:
Editing user in your account strips roles
Steps to Reproduce:
2. Click my account and change a single field.
3. Click the submit button
Actual results: (normal user) !!
Expected results: the roles of the past
Refactored our Actions for this. Basically, the problem was that we were calling
the same action for both self editing and when an admin edits an account. For
the self editing we don't edit roles, therefore our action gets null for the new
role set. For the admin editing action, we weren't ever removing roles from a
user. When I fixed this, the self edit broke because the action didn't know if
it got null because the user wasn't allowed to select any roles, or because all
roles had been removed.
We now have two actions with the commonality factored out into a helper class.