Created attachment 1405797 [details] Screen shot Description of problem: The icon to launch Remmina appears fine in the application list of gnome-shell, but after launching Remmina, it has no icon for the running application. I attach a screenshot. This is a Wayland gnome-shell session in a fully updated F27. Version-Release number of selected component (if applicable): remmina-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-rdp-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-secret-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-nx-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-xdmcp-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-vnc-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64 remmina-plugins-exec-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64
freerdp-2.0.0-39.20180314gitf8baeb7.fc28 remmina-1.2.0-0.48.20180314.git.04e4a99.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f754a46985
remmina-1.2.0-0.48.20180314.git.04e4a99.fc27 freerdp-2.0.0-39.20180314gitf8baeb7.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b3bda07364
freerdp-2.0.0-39.20180314gitf8baeb7.fc26 remmina-1.2.0-0.48.20180314.git.04e4a99.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-05115b29ba
(In reply to Fedora Update System from comment #2) > remmina-1.2.0-0.48.20180314.git.04e4a99.fc27 > freerdp-2.0.0-39.20180314gitf8baeb7.fc27 has been submitted as an update to > Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b3bda07364 As was previously stated in comment 0, originally, under fedora 27 "The icon to launch Remmina appears fine in the application list of gnome-shell". After updating all of the installed components with those posted here, this Icon, and in fact the entire entry to launch Remmina, no longer appears in the application list of gnome-shell.
freerdp-2.0.0-39.20180314gitf8baeb7.fc28, remmina-1.2.0-0.48.20180314.git.04e4a99.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f754a46985
freerdp-2.0.0-39.20180314gitf8baeb7.fc26, remmina-1.2.0-0.48.20180314.git.04e4a99.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-05115b29ba
freerdp-2.0.0-39.20180314gitf8baeb7.fc27, remmina-1.2.0-0.48.20180314.git.04e4a99.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b3bda07364
The Remmina icon has disappeared in remmina-1.2.0-0.48.20180314.git.04e4a99.fc27.x86_64
freerdp-2.0.0-39.20180314gitf8baeb7.fc27, remmina-1.2.0-0.48.20180314.git.04e4a99.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
The problem has not been resolved. remmina-1.2.0-0.48.20180314.git.04e4a99.fc27.x86_64
Upstream developer here. In other distros works fine, what it's different in Fedora that doesn't deal correctly with the Remmina desktop file? Any clues? Thanks.
Can someone see if there is one or more remmina desktop files under /usr/share/applications ? Can you share those files please?
There is only one and is identical before and after the Remmina upgrade.
Created attachment 1409850 [details] /usr/share/applications/remmina-file.desktop
The file permissions are also the same before and after. -rw-r--r--. 1 root root 232 Mar 15 04:34 /usr/share/applications/remmina-file.desktop
Desktop files are just installed as they are: https://src.fedoraproject.org/rpms/remmina/blob/master/f/remmina.spec#_197 https://src.fedoraproject.org/rpms/remmina/blob/master/f/remmina.spec#_212 There are only these two installed: $ ls -al /usr/share/applications/*remmina* -rw-r--r--. 1 root root 5182 Mar 19 13:14 /usr/share/applications/org.remmina.Remmina.desktop -rw-r--r--. 1 root root 232 Mar 15 09:34 /usr/share/applications/remmina-file.desktop Nothing special in both that should justify the icon disappearing. The only thing that seems to be wrong is the name of the desktop file in the AppData file, but this has nothing to do with the icon disappearing: $ grep "\\.desktop" /usr/share/metainfo/org.remmina.Remmina.appdata.xml <id>org.Remmina.desktop</id> (should be org.remmina.Remmina.desktop).
While I'm at it, I'm opening a bug for the metadata file so it does not get lost, it also fails on other things (unrelated to this particular problem).
However, removing the line "NoDisplay-true" from the desktop file fixes the issue.
typo there. I meant "NoDisplay=true"
Cool! Thanks Bill. I'm going to fix this upstream immediately (both). Thanks really!!
Ah! Cool. I will wait for the next code drop and just rebase on that then. Thanks!
So much for the usefulness of desktop-file-validate, it does not print anything: $ desktop-file-validate /usr/share/applications/org.remmina.Remmina.desktop /usr/share/applications/org.remmina.Remmina.desktop: warning: key "OnlyShowIn" in group "Desktop Action Quit" is deprecated $ desktop-file-validate /usr/share/applications/remmina-file.desktop $ echo $? 0 @anter(In reply to Antenore Gatta from comment #20) > Cool! Thanks Bill. > I'm going to fix this upstream immediately (both). > > Thanks really!! What about this? https://bugzilla.redhat.com/show_bug.cgi?id=1557572 Also the main icon is missing with the latest snapshot.
Did you build the latest commits from this PR https://github.com/FreeRDP/Remmina/pull/1522 ?
Done, directly in next, I hope I'm not breaking something else :-)
(In reply to Antenore Gatta from comment #23) > Did you build the latest commits from this PR > https://github.com/FreeRDP/Remmina/pull/1522 ? Doing in one pass when all changes are in: - Removal of NoDisplay=true (merged) - Fixing of AppStream metadata desktop file (merged) - Removal of OnlyShowIn=Unity; (merged) - Removal of "%u" in the exec lines (not yet merged)
(In reply to Bill Gianopoulos from comment #18) > However, removing the line "NoDisplay=true" from the desktop file fixes the > issue. Bill, if you remove that entry from the remote-file.desktop you have an additional icon in the menu called "Remmina Remote File" that actually does nothing once clicked. Are you sure this is the intended behaviour? Do you require two icons in the menu, one not working, to have an icon in the running applications?
OK not at all sure how this ever worked before. I restored the line "NoDisplay=true" to remmina-file.desktop, and created an additiona desktop file named remmina-desktop and put these lines in it: [Desktop Entry] Name=Remmina Comment=Access remote desktops with Remmina Exec=/usr/bin/remmina Icon=remmina Terminal=false Type=Application StartupNotify=true Under fedora this results in only one Icon and clicking on it actually launches remmina. The reason the other icon did not work was because of it specifying the --connect option with no parameter to specify the connection to be used. Is it possible that fixing the Appstream metadata would actually just make it work without adding or altering desktop files?
Of course so not doing the remove of "NoDisplay=true" form remmina-file.desktop is the correct thing to do fixing the other issue should result in a usable icon because of the existence of an /usr/share/applications/org.remmina.Remmina.desktop file that i did not see earlier because I had only looked for files beginning with remmina.
Created attachment 1409890 [details] /usr/share/applications/org.remmina.Remmina.desktop OK and this is the contents of the new desktop file.
(In reply to Simone Caronni from comment #25) > (In reply to Antenore Gatta from comment #23) > > Did you build the latest commits from this PR > > https://github.com/FreeRDP/Remmina/pull/1522 ? > > Doing in one pass when all changes are in: > > - Removal of NoDisplay=true (merged) > - Fixing of AppStream metadata desktop file (merged) > - Removal of OnlyShowIn=Unity; (merged) > - Removal of "%u" in the exec lines (not yet merged) So I think reverting the Removal of NoDisplay=true, not doing the removal of "%u" in exec lines and maybe even reverting the OnlyShowIn=Unity change and just do the Fixing of AppStream metadata desktop file and testing that because maybe all of the other issues go away.
There is a bit of confusion here. (In reply to Bill Gianopoulos from comment #27) > OK not at all sure how this ever worked before. I restored the line > "NoDisplay=true" to remmina-file.desktop, and created an additiona desktop > file named remmina-desktop and put these lines in it: > > [Desktop Entry] > Name=Remmina > Comment=Access remote desktops with Remmina > Exec=/usr/bin/remmina > Icon=remmina > Terminal=false > Type=Application > StartupNotify=true This you should not do, as this is what the org.remmina.Remmina.desktop file is about. > > Under fedora this results in only one Icon and clicking on it actually > launches remmina. The reason the other icon did not work was because of it > specifying the --connect option with no parameter to specify the connection > to be used. Is it possible that fixing the Appstream metadata would > actually just make it work without adding or altering desktop files? Nope, not related. Making a test build to see if everything works and "NoDisplay=true" really needs to be removed (thus having two menu entries) to have an icon in the running application list. (In reply to Bill Gianopoulos from comment #30) > So I think reverting the Removal of NoDisplay=true, not doing the removal of > "%u" in exec lines and maybe even reverting the OnlyShowIn=Unity change and > just do the Fixing of AppStream metadata desktop file and testing that > because maybe all of the other issues go away. No, this is wrong. Metadata has nothing to do with this. I'm making a test. Correct thing seems to be: - Fixing of AppStream metadata desktop file (merged) - Removal of OnlyShowIn=Unity; (merged) - Removal of "%u" in the exec lines (merged) - KEEP NoDisplay=true in remote-file.desktop (to be reverted) I will ask the original poster for testing the update.
remmina-1.2.0-0.49.20180319.git.5f3cc40.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c71246ae99
Juan, can you test the above update? It contains the above changes, so you should see 2 Remmina icons. If the icon is correctly displayed in the running applications list, can you then try to see if adding "NoDisplay=true" to the end of "/usr/share/applications/remmina-file.desktop" still shows the icon in the applications list? Thanks.
(In reply to Simone Caronni from comment #33) > Juan, can you test the above update? > > It contains the above changes, so you should see 2 Remmina icons. If the > icon is correctly displayed in the running applications list, can you then > try to see if adding "NoDisplay=true" to the end of > "/usr/share/applications/remmina-file.desktop" still shows the icon in the > applications list? > > Thanks. OK I applied the above and had the extra non-working icon and re-added the NoDisplay=true and it all seems to work as it should. Sorry for leading you down the wrong path here.
remmina-1.2.0-0.49.20180319.git.5f3cc40.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c71246ae99
freerdp-2.0.0-39.20180314gitf8baeb7.fc26, remmina-1.2.0-0.48.20180314.git.04e4a99.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
(In reply to Bill Gianopoulos from comment #34) > Sorry for leading you down the wrong path here. No problem! Thanks for confirming.
Antenore reverted the nodisplay change, will rebuild immediately.
remmina-1.2.0-0.49.20180319.git.5f3cc40.fc27.x86_64 fixes all icon issues. Thank you!
freerdp-2.0.0-40.20180320gitde83f4d.fc28 remmina-1.2.0-0.50.20180321.git.f467f19.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f754a46985
freerdp-2.0.0-40.20180320gitde83f4d.fc27 remmina-1.2.0-0.50.20180321.git.f467f19.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c71246ae99
freerdp-2.0.0-40.20180320gitde83f4d.fc28, remmina-1.2.0-0.50.20180321.git.f467f19.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f754a46985
freerdp-2.0.0-40.20180320gitde83f4d.fc27, remmina-1.2.0-0.50.20180321.git.f467f19.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c71246ae99
freerdp-2.0.0-40.20180320gitde83f4d.fc27, remmina-1.2.0-0.50.20180321.git.f467f19.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
freerdp-2.0.0-40.20180320gitde83f4d.fc28, remmina-1.2.0-0.50.20180321.git.f467f19.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.