Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1553118

Summary:	[downstream clone - 3.6.13] [downstream clone - 3.6.13] [downstream clone - 4.1.10] After cold merge in version earlier than 4.1, cold merge will fail in versions greater or equal 4.1.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	RHV bug bot <rhv-bugzilla-bot>
Component:	vdsm	Assignee:	Ala Hino <ahino>
Status:	CLOSED ERRATA	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	amarchuk, amureini, bazulay, bcholler, bugs, dfodor, gwatson, kgoldbla, lsurette, mkalinin, nsoffer, srevivo, tnisan, ycui, ykaul, ylavi
Target Milestone:	ovirt-3.6.13	Keywords:	ZStream
Target Release:	---	Flags:	lsvaty: testing_plan_complete-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1547894	Environment:
Last Closed:	2018-03-27 11:32:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1547894
Bug Blocks:

Description RHV bug bot 2018-03-08 10:52:18 UTC

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1547894 +++
======================================================================

+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1544553 +++
======================================================================

+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1538472 +++
======================================================================

Description of problem:
After renaming a volume we must reinitialize the volume lease, since
sanlock does not allow querying or acquiring a lease without the correct
lease name.

Steps to Reproduce:
1. create a 4.0 dc
2. create a vm with a single disk
3. create two snapshots: s1 and s2
4. cold merge s1
5. upgrade the dc to 4.1
6. cold merge s2

Actual results:
Following error is raised and the merge fails:

2018-01-21 15:23:48,241+0200 ERROR (tasks/3) [storage.TaskManager.Task] (Task='d1823d98-2e55-4a70-82f6-26532a76ee57') Unexpected error (task:875)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 882, in _run
    return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 336, in run
    return self.cmd(*self.argslist, **self.argsdict)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line 79, in wrapper
    return method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/sp.py", line 1862, in prepareMerge
    merge.prepare(subchainInfo)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/merge.py", line 178, in prepare
    with guarded.context(subchain.locks):
  File "/usr/lib/python2.7/site-packages/vdsm/storage/guarded.py", line 102, in __enter__
    six.reraise(*exc)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/guarded.py", line 93, in __enter__
    lock.acquire()
  File "/usr/lib/python2.7/site-packages/vdsm/storage/volume.py", line 1516, in acquire
    dom.acquireVolumeLease(self._host_id, self._img_id, self._vol_id)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/sd.py", line 475, in acquireVolumeLease
    self._domainLock.acquire(hostId, lease)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/clusterlock.py", line 409, in acquire
    "Cannot acquire %s" % (lease,), str(e))
AcquireLockFailure: Cannot obtain lock: u"id=aafed42c-8cc1-4710-ac79-0e9c55420675, rc=-227, out=Cannot acquire Lease(name='fe81c224-210e-4735-b4b6-ffe890581b01', path=u'/rhev/data-center/mnt/rich-nfs-server2.usersys.redhat.com:_home_storage_sd1/aafed42c-8cc1-4710-ac79-0e9c55420675/images/ae9ed879-ae1b-47e4-bcd1-8551972761c4/fe81c224-210e-4735-b4b6-ffe890581b01.lease', offset=0), err=(-227, 'Sanlock resource not acquired', 'Lease resource name is incorrect')"


Expected results:
Cold merge to pass.

(Originally by Ala Hino)

(Originally by rhev-integ)

(Originally by rhv-bugzilla-bot)

Comment 1 RHV bug bot 2018-03-08 10:52:29 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

(Originally by rule-engine)

(Originally by rhev-integ)

(Originally by rhv-bugzilla-bot)

Comment 6 Ala Hino 2018-03-12 12:54:34 UTC

Steps to verify:

1. create a 3.6 DC
2. create a VM with a disk on block domain
3. create two snapshots: s1 and s2
4. cold merge s1 (the first snapshot created)
5. upgrade the DC to 4.1
6. cold merge s2 ==> should successfully complete

Please note that the verification is done using the same VM.

Comment 8 Kevin Alon Goldblatt 2018-03-14 23:18:31 UTC

Verified with the following code:
-----------------------------------------
vdsm-4.17.43.1-1.el7ev for 3.6 and then at step 4 upgraded to 4.1 vdsm-4.19.50-1.el7ev.x86_64
ovirt-engine-4.2.2.2-0.1.el7.noarch


Verified with the following scenario:
----------------------------------------
1. create a 3.6 DC
2. create a VM with a disk on block domain
3. create two snapshots: s1 and s2
4. cold merge s1 (the first snapshot created)
5. upgrade the DC to 4.1
6. cold merge s2 ==> should successfully complete



Moving to VERIFIED

Comment 9 Ala Hino 2018-03-18 10:14:04 UTC

(In reply to Kevin Alon Goldblatt from comment #8)
> Verified with the following code:
> -----------------------------------------
> vdsm-4.17.43.1-1.el7ev for 3.6 and then at step 4 upgraded to 4.1
> vdsm-4.19.50-1.el7ev.x86_64
> ovirt-engine-4.2.2.2-0.1.el7.noarch
> 
> 
> Verified with the following scenario:
> ----------------------------------------
> 1. create a 3.6 DC
> 2. create a VM with a disk on block domain
> 3. create two snapshots: s1 and s2
> 4. cold merge s1 (the first snapshot created)
> 5. upgrade the DC to 4.1
> 6. cold merge s2 ==> should successfully complete
> 
> 
> 
> Moving to VERIFIED

Please note that this is the 3.6-els bug that must be verified with the corresponding build - vdsm-4.17.44-4.el7ev.

The verification done here is valid for BZ 1547894.

Comment 10 Kevin Alon Goldblatt 2018-03-21 18:11:18 UTC

 Verified with the following code:
---------------------------------------
3.6.13.4 and then at step 4 upgraded to 4.1
ovirt-engine-4.2.2.2-0.1.el7.noarch


Verified with the following scenario:
----------------------------------------
1. create a 3.6.13.4 DC with compatability version 3.6
2. create a VM with a disk on block domain
3. create two snapshots: s1 and s2
4. cold merge s1 (the first snapshot created)
5. upgrade the DC to 4.1
6. cold merge s2 ==> should successfully complete
> 
> 
> 
> Moving to VERIFIED

Comment 11 Ala Hino 2018-03-21 18:53:32 UTC

Thanks, Kevin.

Can you please confirm that tested vdsm version is vdsm-4.17.44-4.el7ev?

Comment 12 Kevin Alon Goldblatt 2018-03-22 08:09:18 UTC

(In reply to Ala Hino from comment #11)
> Thanks, Kevin.
> 
> Can you please confirm that tested vdsm version is vdsm-4.17.44-4.el7ev?

Yes the version is:
Vdsm version 3.6.13.4 as provided by rhev-integ
vdsm-4.17.44-4.el7ev

Comment 15 errata-xmlrpc 2018-03-27 11:32:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0598

Comment 16 Franta Kust 2019-05-16 13:04:22 UTC

BZ<2>Jira Resync

Comment 17 Daniel Gur 2019-08-28 13:12:12 UTC

sync2jira

Comment 18 Daniel Gur 2019-08-28 13:16:25 UTC

sync2jira