Bug 1553622 - Review Request: perl-Gtk3-SimpleList - Simple interface to Gtk3's complex MVC list widget
Summary: Review Request: perl-Gtk3-SimpleList - Simple interface to Gtk3's complex MVC...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1553142
TreeView+ depends on / blocked
 
Reported: 2018-03-09 08:14 UTC by Petr Pisar
Modified: 2018-03-12 13:52 UTC (History)
2 users (show)

Fixed In Version: perl-Gtk3-SimpleList-0.17-1.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-12 13:52:17 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2018-03-09 08:14:44 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Gtk3-SimpleList/perl-Gtk3-SimpleList.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Gtk3-SimpleList/perl-Gtk3-SimpleList-0.17-1.fc29.src.rpm
Description:
Gtk3 has a powerful, but complex MVC (Model, View, Controller) system used
to implement list and tree widgets. Gtk3::SimpleList Perl module automates the
complex setup work and allows you to treat the list model as a more natural
list of lists structure.

Fedora Account System Username: ppisar

Comment 1 Robert-André Mauchin 🐧 2018-03-09 17:48:52 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: ed201f74a9ff3542b7cc260159e87ca5894c24a5b182a39d6f86bb84669c9053) is original. Ok.
Summary verified from lib/Gtk3/SimpleList.pm. Ok.
Description verified from lib/Gtk3/SimpleList.pm. Ok.
License verified from llib/Gtk3/SimpleList.pm and README.md. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Gtk3-SimpleList.spec review-perl-Gtk3-SimpleList/results/perl-Gtk3-SimpleList-0.17-1.fc29.noarch.rpm review-perl-Gtk3-SimpleList/results/perl-Gtk3-SimpleList-0.17-1.fc29.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv perl-Gtk3-SimpleList-0.17-1.fc29.noarch.rpm      18:37:31
drwxr-xr-x    2 root    root                        0 mars  9 18:33 /usr/share/doc/perl-Gtk3-SimpleList
-rw-r--r--    1 root    root                      128 nov. 23  2013 /usr/share/doc/perl-Gtk3-SimpleList/Changes
-rw-r--r--    1 root    root                     1326 nov. 23  2013 /usr/share/doc/perl-Gtk3-SimpleList/README
drwxr-xr-x    2 root    root                        0 mars  9 18:33 /usr/share/licenses/perl-Gtk3-SimpleList
-rw-r--r--    1 root    root                    26527 avril  1  2012 /usr/share/licenses/perl-Gtk3-SimpleList/COPYING
-rw-r--r--    1 root    root                     5957 mars  9 18:33 /usr/share/man/man3/Gtk3::SimpleList.3pm.gz
drwxr-xr-x    2 root    root                        0 mars  9 18:33 /usr/share/perl5/vendor_perl/Gtk3
-rw-r--r--    1 root    root                    24594 nov.  6 08:57 /usr/share/perl5/vendor_perl/Gtk3/SimpleList.pm

File permissions and layout are Ok.

$ rpm -q --requires -p perl-Gtk3-SimpleList-0.17-1.fc29.noarch.rpm  | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Gtk3)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Gtk3-SimpleList-0.17-1.fc29.noarch.rpm 
perl(Gtk3::SimpleList) = 0.17
perl(Gtk3::SimpleList::TiedList)
perl(Gtk3::SimpleList::TiedRow)
perl-Gtk3-SimpleList = 0.17-1.fc29
Binary provides are Ok.

Package builds in F28: https://koji.fedoraproject.org/koji/taskinfo?taskID=25585295
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

Comment 2 Gwyn Ciesla 2018-03-12 13:29:43 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Gtk3-SimpleList

Comment 3 Petr Pisar 2018-03-12 13:52:17 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.