Bug 1553730 - Review Request: golang-github-coreos-bbolt - An embedded key/value database for Go
Summary: Review Request: golang-github-coreos-bbolt - An embedded key/value database f...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jakub Čajka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-09 12:29 UTC by Jan Chaloupka
Modified: 2018-03-30 12:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-19 20:52:11 UTC
Type: ---
Embargoed:
jcajka: fedora-review+


Attachments (Terms of Use)

Description Jan Chaloupka 2018-03-09 12:29:14 UTC
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-coreos-bbolt/golang-github-coreos-bbolt.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-coreos-bbolt/golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc24.src.rpm

Description: An embedded key/value database for Go

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=25579403

$ rpmlint golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc24.src.rpm golang-github-coreos-bbolt-devel-1.3.1-0.1.coreos.5.20180309git32c383e.fc24.x86_64.rpm
golang-github-coreos-bbolt.src: W: no-%build-section
golang-github-coreos-bbolt.src: E: specfile-error Forge-specific packaging variables
golang-github-coreos-bbolt.src: E: specfile-error   forgeurl:        https://github.com/coreos/bbolt
golang-github-coreos-bbolt.src: E: specfile-error   forgesource:     https://github.com/coreos/bbolt/archive/32c383e75ce054674c53b5a07e55de85332aee14/bbolt-32c383e75ce054674c53b5a07e55de85332aee14.tar.gz
golang-github-coreos-bbolt.src: E: specfile-error   forgesetupargs:  -n bbolt-32c383e75ce054674c53b5a07e55de85332aee14
golang-github-coreos-bbolt.src: E: specfile-error Generic variables
golang-github-coreos-bbolt.src: E: specfile-error   archivename:     bbolt-32c383e75ce054674c53b5a07e55de85332aee14
golang-github-coreos-bbolt.src: E: specfile-error   archiveext:      tar.gz
golang-github-coreos-bbolt.src: E: specfile-error   archiveurl:      https://github.com/coreos/bbolt/archive/32c383e75ce054674c53b5a07e55de85332aee14/bbolt-32c383e75ce054674c53b5a07e55de85332aee14.tar.gz
golang-github-coreos-bbolt.src: E: specfile-error   scm:             git
golang-github-coreos-bbolt.src: E: specfile-error   tag:             
golang-github-coreos-bbolt.src: E: specfile-error   commit:          32c383e75ce054674c53b5a07e55de85332aee14
golang-github-coreos-bbolt.src: E: specfile-error   dist:            .20180309git32c383e.fc24 (snapshot date is computed once %{_sourcedir}/%{archivename}.%{archiveext} is available)
golang-github-coreos-bbolt-devel.x86_64: W: hidden-file-or-dir /usr/share/gocode/src/github.com/coreos/bbolt/.goipath
golang-github-coreos-bbolt-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/coreos/bbolt/.goipath
2 packages and 0 specfiles checked; 13 errors, 2 warnings.

Comment 1 Jan Chaloupka 2018-03-09 12:31:52 UTC
The rpmlint does not like:

Forge-specific packaging variables
  forgeurl:        https://github.com/coreos/bbolt
  forgesource:     https://github.com/coreos/bbolt/archive/32c383e75ce054674c53b5a07e55de85332aee14/bbolt-32c383e75ce054674c53b5a07e55de85332aee14.tar.gz
  forgesetupargs:  -n bbolt-32c383e75ce054674c53b5a07e55de85332aee14
Generic variables
  archivename:     bbolt-32c383e75ce054674c53b5a07e55de85332aee14
  archiveext:      tar.gz
  archiveurl:      https://github.com/coreos/bbolt/archive/32c383e75ce054674c53b5a07e55de85332aee14/bbolt-32c383e75ce054674c53b5a07e55de85332aee14.tar.gz
  scm:             git
  tag:             
  commit:          32c383e75ce054674c53b5a07e55de85332aee14
  dist:            .20180309git32c383e.fc24 (snapshot date is computed once %{_sourcedir}/%{archivename}.%{archiveext} is available)

which is just a verbose output of the gometa macro. It can be ignored.

The same holds for /usr/share/gocode/src/github.com/coreos/bbolt/.goipath. It is a lockfile used to automatically detect import path prefixes for auto-generated list of Provided and Required packages.

Comment 2 Jakub Čajka 2018-03-09 12:48:48 UTC
LGTM

Comment 4 Gwyn Ciesla 2018-03-09 15:02:27 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-coreos-bbolt

Comment 5 Fedora Update System 2018-03-09 15:38:58 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-36e840bcc6

Comment 6 Fedora Update System 2018-03-09 15:39:07 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9098bc744b

Comment 7 Fedora Update System 2018-03-09 23:26:42 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9098bc744b

Comment 8 Fedora Update System 2018-03-11 20:58:14 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-36e840bcc6

Comment 9 Fedora Update System 2018-03-19 20:52:11 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-03-30 12:48:18 UTC
golang-github-coreos-bbolt-1.3.1-0.1.coreos.5.20180309git32c383e.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.