Bug 1554079 - typo in libvirt/src/locking/virtlockd-admin.socket.in (and a request)
Summary: typo in libvirt/src/locking/virtlockd-admin.socket.in (and a request)
Keywords:
Status: CLOSED DUPLICATE of bug 1586239
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-11 10:13 UTC by dac.override
Modified: 2018-06-19 19:29 UTC (History)
12 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-06-19 19:29:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description dac.override 2018-03-11 10:13:36 UTC
Description of problem:

There is a typo in "libvirt/src/locking/virtlockd-admin.socket.in" on line 7

- Server=virtlockd.service
+ Service=virtlockd.service

Request:

Please make "ListenStream=@localstatedir@/run/libvirt" in *all* (logging and locking) of the socket units translate to "/run/libvirt" instead of "/var/run/libvirt"

Using /var/run in systemd socket units can cause issue due to the way systemd processes these units.

Version-Release number of selected component (if applicable):
libvirt-daemon-4.1.0-1.fc29.x86_64

How reproducible:
systemd-analyze verify virtlockd-admin.socket

Comment 1 Jiri Denemark 2018-03-12 08:22:26 UTC
*** Bug 1554086 has been marked as a duplicate of this bug. ***

Comment 2 Cole Robinson 2018-03-24 20:17:14 UTC
Thanks for the report. That first issue was fixed upstream and will be in the next release:

commit fb327ac2c3d721b4002852c520d9f39a35183e0d
Author: Jim Fehlig <jfehlig>
Date:   Wed Mar 14 16:42:39 2018 -0600

    lockd: fix typo in virtlockd-admin.socket


Can you expand more on the second issue? Looking at services installed on my machine, most use /run but some use /var/run like sssd and cups. Is there a link with more info? Is /run standard for all systemd distros?

Comment 3 dac.override 2018-03-24 20:19:34 UTC
See this thread: https://bugzilla.redhat.com/show_bug.cgi?id=1557622

Comment 4 Cole Robinson 2018-06-19 19:29:43 UTC
This issue is fixed in rawhide now but not f28. Duping to the f28 bug

*** This bug has been marked as a duplicate of bug 1586239 ***


Note You need to log in before you can comment on or make changes to this bug.