Bug 1554116 - "Ignore OVF update failure" checkbox when disabling a non-data domain
Summary: "Ignore OVF update failure" checkbox when disabling a non-data domain
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.2
: ---
Assignee: Eyal Shenitzky
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-11 14:43 UTC by Allon Mureinik
Modified: 2018-03-29 10:55 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.2.2.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 10:55:36 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: exception+


Attachments (Terms of Use)
screenshot (103.99 KB, image/png)
2018-03-11 14:43 UTC, Allon Mureinik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1321585 0 medium CLOSED [RFE] Add option to deactivate storage domain only if ovf store was updated 2021-02-22 00:41:40 UTC
oVirt gerrit 88787 0 master MERGED webadmin: hide 'Ignore OVF failure' checkbox for non data domains 2018-03-13 11:42:09 UTC
oVirt gerrit 88900 0 ovirt-engine-4.2 MERGED webadmin: hide 'Ignore OVF failure' checkbox for non data domains 2018-03-13 12:42:48 UTC

Internal Links: 1321585

Description Allon Mureinik 2018-03-11 14:43:34 UTC
Created attachment 1406894 [details]
screenshot

Description of problem:
When disabling a domain in the webadmin, a popup with an "Ignore OVF update failure" checkbox is displayed, regardless of the domain's type.
Since the OVF Storage exists only on data-domain, the backend should ignore this option all together for non data domains (ISO, export, etc), and the GUI should not display the checkbox.

Version-Release number of selected component (if applicable):
oVirt Engine 4.3 build from source with commit e3727880ec2. The same problem should also occur in 4.2.2, as it was introduced by the fix to bug 1321585.

How reproducible:
100%

Steps to Reproduce:
1. Create a DC with a master domain and an export domain
2. Navigate to Storage->Domains
3. Select the export domain
4. Navigate to "Data Center"
5. Choose the DC the domain belongs to and click maintenance.

(A similar flow should occur for ISO, although I have not tested it).

Actual results:
The confirmation dialog has the aforementioned checkbox (see attached screenshot).

Expected results:
No checkbox in the confirmation dialog.

Additional info:

Comment 1 Kevin Alon Goldblatt 2018-03-22 09:24:23 UTC
Verified with the following code:
-----------------------------------
ovirt-engine-4.2.2.4-0.1.el7.noarch
vdsm-4.20.22-1.el7ev.x86_64


Verified with the following scenario:
--------------------------------------
Steps to Reproduce:
1. Create a DC with a master domain and an export domain
2. Navigate to Storage->Domains
3. Select the export domain
4. Navigate to "Data Center"
5. Choose the DC the domain belongs to and click maintenance.

The checkbox  is no longer displayed in the confirmation dialog.


Moving to VERIFIED

Comment 2 Sandro Bonazzola 2018-03-29 10:55:36 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.