Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1555368

Summary: Network prefix length value is pre-filled but not effective if the user doesn't retype it.
Product: [oVirt] cockpit-ovirt Reporter: Simone Tiraboschi <stirabos>
Component: Hosted EngineAssignee: Phillip Bailey <phbailey>
Status: CLOSED CURRENTRELEASE QA Contact: Yihui Zhao <yzhao>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 0.11.12CC: bugs, cshao, huzhao, jiaczhan, lveyde, phbailey, qiyuan, stirabos, weiwang, yaniwang, ycui, yzhao
Target Milestone: ovirt-4.2.3Flags: rule-engine: ovirt-4.2+
yzhao: testing_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.21-0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-10 06:33:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot 1
none
Screenshot 2 none

Description Simone Tiraboschi 2018-03-14 14:50:46 UTC 
Description of problem:
Network prefix length value is pre-filled but not effective if the user doesn't retype it.

Compare screenshot 1 with screenshot 2

Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard.noarch        0.11.16-1.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Try deploying hosted-engine from cockpit
2. Keep the default network prefix length value 
3. Double check it in preview tab

Actual results:
There is a default in the first tab but it got lost if the user doesn't retype it

Expected results:
The default is correctly consumed

Additional info:
Comment 1 Simone Tiraboschi 2018-03-14 14:51:47 UTC 
Created attachment 1408046 [details]
Screenshot 1
Comment 2 Simone Tiraboschi 2018-03-14 14:52:19 UTC 
Created attachment 1408047 [details]
Screenshot 2
Comment 3 Simone Tiraboschi 2018-03-14 15:19:07 UTC 
*** Bug 1555366 has been marked as a duplicate of this bug. ***
Comment 4 Phillip Bailey 2018-03-14 15:25:33 UTC 
(In reply to Simone Tiraboschi from comment #0)
> Description of problem:
> Network prefix length value is pre-filled but not effective if the user
> doesn't retype it.

> Actual results:
> There is a default in the first tab but it got lost if the user doesn't
> retype it

The text that's there is a placeholder, not a pre-filled value. It's the same as it is for the IP value. It's to show what type of value is expected to be entered there, but the field still has to be filled in.

> Expected results:
> The default is correctly consumed

We can add a default value or we can mark it as required, which will alert the user that it needs to be filled in.
Comment 5 Yihui Zhao 2018-03-19 09:28:11 UTC 
Tested with 11.17, from the Comment 4, it is not a pre-filled value. 

Or consider to add a default value or mark it as required.
Comment 6 Yihui Zhao 2018-04-13 01:59:39 UTC 
Tested with cockpit-ovirt-0.11.21-0.1, now the network prefix length value is marked as required, which will alert the user that it needs to be filled in.


So moving to verified.
Comment 7 Sandro Bonazzola 2018-05-10 06:33:41 UTC 
This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.