Bug 1555426 – yedit module should generate uniquely named backup files

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1555426 - yedit module should generate uniquely named backup files

Summary:	yedit module should generate uniquely named backup files

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Installer (Show other bugs)
Sub Component:
Version:	3.9.0
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	3.9.z
Assigned To:	Fabian von Feilitzsch
QA Contact:	liujia
Docs Contact:

URL:
Whiteboard:
Keywords:

Duplicates:	1558880 (view as bug list)
Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2018-03-14 12:53 EDT by Scott Dodson
Modified:	2018-05-17 02:43 EDT (History)
CC List:	6 users (show)

See Also:	1558880
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	Feature: yedit module now generates unique backup files Reason: If changes were made to the same resource multiple times, only the latest diff would be saved. Result: yedit module now generates unique backup files
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-05-17 02:42:42 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:1566	None	None	None	2018-05-17 02:43 EDT

Groups: None (edit)

Description Scott Dodson 2018-03-14 12:53:36 EDT

Currently, the yedit module backs up files whenever it edits a file. In order to allow for audit trail of changes it'd be beneficial if those backups were named with the timestamp so that subsequent writes do not lose history.

Comment 1 Fabian von Feilitzsch 2018-03-16 13:22:04 EDT

https://github.com/openshift/openshift-ansible/pull/7558

Comment 2 liujia 2018-03-21 21:56:09 EDT

*** Bug 1558880 has been marked as a duplicate of this bug. ***

Comment 3 openshift-github-bot 2018-03-28 21:56:04 EDT

Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/bc2ad50e5951bca0857f6bf947ec0cffbdf11dce
Bug 1555426- yedit now appends an ISO8601 formatted datetime string to file backups

https://github.com/openshift/openshift-ansible/commit/f28aba492e10048d30b49f39f02ee9a2f9be2c64
Merge pull request #7558 from fabianvf/bz1555426

Bug 1555426- yedit now appends an ISO8601 formatted datetime string to file backups

Comment 4 Scott Dodson 2018-03-28 21:57:25 EDT

https://github.com/openshift/openshift-ansible/pull/7701 release-3.9

Comment 6 liujia 2018-04-18 05:27:16 EDT

blocked by bug1566238

Comment 8 liujia 2018-04-19 23:21:43 EDT

Verified on openshift-ansible-3.9.24-1.git.0.d0289ea.el7.noarch

# ls -la /etc/origin/master/ |grep master-config
-rw-r--r--. 1 root root   5966 Apr 19 22:49 master-config.yaml
-rw-r--r--. 1 root root   6413 Apr 19 22:40 master-config.yaml.20180419T224055
-rw-r--r--. 1 root root   6447 Apr 19 22:49 master-config.yaml.20180419T224935
-rw-------. 1 root root   6012 Apr 19 21:30 master-config.yaml.orig

Comment 11 errata-xmlrpc 2018-05-17 02:42:42 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1566

Note You need to log in before you can comment on or make changes to this bug.