Bug 155544 - requeued IO does not have BIO_RW_FAILFAST set.
requeued IO does not have BIO_RW_FAILFAST set.
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: device-mapper-multipath (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alasdair Kergon
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-21 06:52 EDT by Lars Marowsky-Bree
Modified: 2007-11-30 17:11 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-04-21 16:05:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
Move setting BIO_RW_FAILFAST to map_io() (1.10 KB, patch)
2005-04-21 06:52 EDT, Lars Marowsky-Bree
no flags Details | Diff

  None (edit)
Description Lars Marowsky-Bree 2005-04-21 06:52:34 EDT
dm_bio_restore(), called just before requeuing, restores and overwrites our bio
flags. Attached patchlet fixes this.
Comment 1 Lars Marowsky-Bree 2005-04-21 06:52:35 EDT
Created attachment 113463 [details]
Move setting BIO_RW_FAILFAST to map_io()
Comment 2 Alasdair Kergon 2005-04-21 15:55:04 EDT
where does the overwriting happen?
bio_record.h doesn't touch bi_rw
Comment 3 Lars Marowsky-Bree 2005-04-21 16:05:29 EDT
Brown paper bag. You're right. I got confused by the setting of bi_flags, but
bi_rw_failfast is in a different field as you correctly point out; maybe I was
looking for bugs a little bit _too_ hard.

Closing bug, patch not needed ;)

Note You need to log in before you can comment on or make changes to this bug.