Bug 1556974 - Aliases don't behave correctly for plugins
Summary: Aliases don't behave correctly for plugins
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: xmvn
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-15 16:21 UTC by Michael Simacek
Modified: 2018-04-03 06:31 UTC (History)
5 users (show)

Fixed In Version: 3.0.0-14
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-03 06:31:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michael Simacek 2018-03-15 16:21:27 UTC
Description of problem:
Plugins used via an alias don't work correctly.
For example: hawtjni recently renamed their maven-hawtjni-plugin to hawtjni-maven-plugin. I added an alias:
%mvn_alias :hawtjni-maven-plugin :maven-hawtjni-plugin
The plugin works fine when used via the primary name (hawtjni-maven-plugin), but doesn't work when used via the alias (maven-hawtjni-plugin). It resolves fine, but executes the plugin with incorrect configuration.

Version-Release number of selected component (if applicable):
xmvn-minimal-3.0.0-13.fc28.noarch
maven-lib-3.5.3-1.fc29.noarch

How reproducible:
always

Steps to Reproduce:
1. Clone netty (commit a001671 = current master) and try to build it in f29 mock  with -X passed to %mvn_build
2. Observe it fails
3. Add the following to %prep: sed -i s/hawtjni-maven-plugin/maven-hawtjni-plugin/g `find -name pom.xml`
4. Observe it succeeds and was executed with different config (now contains generatedNativeSourceDirectory key)

Comment 1 Mikolaj Izdebski 2018-03-16 10:49:56 UTC
Fixed upstream: https://github.com/fedora-java/xmvn/commit/0168fb6
Integration test: https://github.com/fedora-java/xmvn/commit/68d0731

Comment 2 Mikolaj Izdebski 2018-03-16 10:52:46 UTC
Fixed in xmvn-3.0.0-14

Comment 3 Fedora Update System 2018-03-16 11:08:17 UTC
xmvn-3.0.0-14.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-77d9bf36e5

Comment 4 Fedora Update System 2018-03-16 14:48:19 UTC
xmvn-3.0.0-14.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-77d9bf36e5

Comment 5 Fedora Update System 2018-03-30 13:02:27 UTC
xmvn-3.0.0-14.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Mikolaj Izdebski 2018-04-03 06:21:43 UTC
I believe that this bug is fixed in xmvn-3.0.0-14,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=1058974

Comment 7 Mikolaj Izdebski 2018-04-03 06:31:48 UTC
I believe that this bug is fixed in xmvn-3.0.0-14,
which is available in Fedora 28, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=1058977


Note You need to log in before you can comment on or make changes to this bug.