RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1557296 - virt-who does not ignore commented out lines that are prefixed with tab space
Summary: virt-who does not ignore commented out lines that are prefixed with tab space
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virt-who
Version: 7.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: pre-dev-freeze
: 7.7
Assignee: Nikos Moumoulidis
QA Contact: Eko
URL:
Whiteboard:
: 1557868 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-16 11:40 UTC by Kenny Tordeurs
Modified: 2021-06-10 15:22 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 12:40:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github candlepin virt-who pull 173 0 None closed 1557296: Ignore commented out lines prefixed with space/tab (ENT-606) 2020-07-08 03:35:26 UTC
Red Hat Product Errata RHBA-2019:2070 0 None None None 2019-08-06 12:41:00 UTC

Description Kenny Tordeurs 2018-03-16 11:40:29 UTC
Description of problem:

When a line that is commented out is prefixed with a tab space the line is taken into account by virt-who

# cat esx.conf 
~~~~
[vcenter]
type=esx
server=vmware.sat6.example.redhat.com
username=administrator
password=xxxxx
owner=xxxxx
env=Library
	#filter_hosts=lab-esx-2.example.redhat.com
~~~

Looking at the output we can sse it's using the filter hosts:

# virt-who -od
~~~
2018-03-16 10:33:27,797 [rhsm.connection DEBUG] MainProcess(20950):MainThread @connection.py:_request:490 - Making request: POST /subscription/hypervisors/1979710?reporter_id=ktordeur-sat58.kenny.lan&cloaked=False&env=Library%0A%23filter_hosts%3Dlab-esx-2.example.redhat.com
~~~


Version-Release number of selected component (if applicable):
virt-who-0.18-6.el6_9.noarch

How reproducible:
100%

Steps to Reproduce:
1. virt-who conf with commented out line prefixed with tab space
2.
3.

Actual results:
Line is taken into account by virt-who

Expected results:
Line not taken into account by virt-who

Additional info:
Can be resolved by adding the # at the start of the line

~~~
[vcenter]
type=esx
server=vmware.sat6.gsslab.pnq.redhat.com
username=administrator
password=RedHat1!
owner=1979710
env=Library
#       #filter_hosts=lab-esx-2.gsslab.rdu2.redhat.com
~~~
~                                                                                                                                                                                                                  
~                                                                                                                                                                                                                  
~                                                                                                                                                                                                                  
~

Comment 2 Kevin Howell 2018-03-19 14:08:28 UTC
> env=Library
> 	#filter_hosts=lab-esx-2.example.redhat.com

Key point is that two lines are being treated as one key/value pair.

Comment 3 Kevin Howell 2018-03-19 14:14:13 UTC
*** Bug 1557868 has been marked as a duplicate of this bug. ***

Comment 4 Kevin Howell 2018-06-13 15:31:59 UTC
Dev: let's try to look for instances of the line feed (seen above as %0A), and warn if we detect this is any config values.

Comment 13 errata-xmlrpc 2019-08-06 12:40:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2070


Note You need to log in before you can comment on or make changes to this bug.