Bug 1557439

+++ This bug was initially created as a clone of Bug #1474413 +++

Description of problem:
Create consistency among questions asked on engine-setup

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170723141021.git463826a.el7.centos.noarch
otopi-1.7.1-0.0.master.20170720151120.git5879c4e.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Run engine-setup without answer file

Picking up 3 specific:
Actual results:
          Configure Image I/O Proxy on this host? (Yes, No) [Yes]: 
          Configure VM Console Proxy on this host (Yes, No) [Yes]: 
          Install ovirt-provider-ovn(Yes, No) [Yes]?:


Expected results:         
          Configure Image I/O Proxy on this host (Yes, No) [Yes]: 
          Configure VM Console Proxy on this host (Yes, No) [Yes]: 
          Install ovirt-provider-ovn (Yes, No) [Yes]:

--- Additional comment from Lukas Svaty on 2017-07-24 10:55:10 EDT ---

also this message should be change:

[ INFO  ] Default OVN provider added to database

To 

[ INFO  ] Adding default OVN provider to database

Stage should inform about what is happening not about what happend as others.

--- Additional comment from Yedidyah Bar David on 2017-07-24 10:59:08 EDT ---

Moved to engine for now.

'Configure Image I/O Proxy on this host?' is in ovirt-imageio.

You might ask doc people for a thorough review.

--- Additional comment from Yedidyah Bar David on 2017-08-09 03:50:38 EDT ---

Please note that for proper tracking you probably need to clone this bug to ovirt-imageio instead of pushing patches to both projects with this single bug. Perhaps it's less important for patches to master (next version, currently 4.2) compared to stable branches.

--- Additional comment from Ido Rosenzwig on 2017-08-09 04:46:13 EDT ---

Removed ovirt-imageio patch tracker.

Bug has been cloned and the patch can be tracked here:
https://bugzilla.redhat.com/show_bug.cgi?id=1479704

--- Additional comment from Lukas Svaty on 2017-10-09 08:05:05 EDT ---

space was fixed for OVN, however no question mark in the end for consistency with other options.

Actual result:
Configure ovirt-provider-ovn (Yes, No) [Yes]: 

Expected result:
Configure ovirt-provider-ovn? (Yes, No) [Yes]:

tested in:
ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.2.0-0.0.master.20171006152719.gitbc9a33d.el7.centos.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.2.0-0.0.master.20171006152719.gitbc9a33d.el7.centos.noarch
ovirt-engine-setup-plugin-websocket-proxy-4.2.0-0.0.master.20171006152719.gitbc9a33d.el7.centos.noarch
ovirt-engine-setup-plugin-ovirt-engine-4.2.0-0.0.master.20171006152719.gitbc9a33d.el7.centos.noarch

However found few more of 2 types:
With ?:
          Configure Image I/O Proxy on this host? (Yes, No) [Yes]: 
          Do you want Setup to configure the firewall? (Yes, No) [Yes]: 
          Where is the DWH database located? (Local, Remote) [Local]: 
          Would you like Setup to automatically configure postgresql and create DWH database, or prefer to perform that manually? (Automatic, Manual) [Automatic]: 
          Where is the Engine database located? (Local, Remote) [Local]: 
          Would you like Setup to automatically configure postgresql and create Engine database, or prefer to perform that manually? (Automatic, Manual) [Automatic]: 
          Use weak password? (Yes, No) [No]: yes
          Do you wish to set the application as the default page of the web server? (Yes, No) [Yes]: 
          Do you wish Setup to configure that, or prefer to perform that manually? (Automatic, Manual) [Automatic]: 


And without Without ?:
          Configure Data Warehouse on this host (Yes, No) [Yes]: 
          Configure VM Console Proxy on this host (Yes, No) [Yes]:
          Configure Engine on this host (Yes, No) [Yes]: 
          Configure WebSocket Proxy on this host (Yes, No) [Yes]:          
          Configure ovirt-provider-ovn (Yes, No) [Yes]:
          Use default credentials (admin@internal) for ovirt-provider-ovn (Yes, No) [Yes]: 

Thus if we wanna keep it without '?' the fix is alright, but we should align all the others as well, leaving the bug open for now.
Can we choose one of the format and use it consistently?

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-10-09 08:05:10 EDT ---

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

--- Additional comment from Lucie Leistnerova on 2018-02-22 07:37:34 EST ---

In ovirt-engine-setup-4.2.2.1-0.1.el7.noarch with ovirt-imageio-common-1.2.1-0.el7ev.noarch is still '?'
Configure Image I/O Proxy on this host? (Yes, No) [Yes]:

But in the patch I can see the fix. So how is the status, should this be also fixed in this BZ?

--- Additional comment from Ido Rosenzwig on 2018-03-05 10:07:22 EST ---

Lucie,

I checked with :
ovirt-imageio-common-1.2.1-0.201802191420.git748bd64.el7.centos.noarch
ovirt-engine-setup-4.2.2.3-0.0.master.20180304080652.git60ddba2.el7.centos.noarch

and the question looks like this:

'Configure Image I/O Proxy on this host (Yes, No) [Yes]:'

--- Additional comment from Lucie Leistnerova on 2018-03-06 06:46:31 EST ---

QA has not 4.2.2.3 build yet, it is not fixed in ovirt-engine-4.2.2.2-0.1.el7.noarch with ovirt-imageio-common-1.2.1-0.el7ev.noarch. Please move it to ON_QA when we have the proper build.

--- Additional comment from Sandro Bonazzola on 2018-03-16 11:07:06 EDT ---

(In reply to Lucie Leistnerova from comment #9)
> QA has not 4.2.2.3 build yet, it is not fixed in
> ovirt-engine-4.2.2.2-0.1.el7.noarch with
> ovirt-imageio-common-1.2.1-0.el7ev.noarch. Please move it to ON_QA when we
> have the proper build.

Proper build is available in http://resources.ovirt.org/pub/ovirt-4.2-pre; you can enable the repo with "yum install http://resources.ovirt.org/pub/yum-repo/ovirt-release42-pre.rpm".

(In reply to Lucie Leistnerova from comment #7)
> In ovirt-engine-setup-4.2.2.1-0.1.el7.noarch with
> ovirt-imageio-common-1.2.1-0.el7ev.noarch is still '?'
> Configure Image I/O Proxy on this host? (Yes, No) [Yes]:
> 
> But in the patch I can see the fix. So how is the status, should this be
> also fixed in this BZ?


Note that the above mentioned question doesn't come from ovirt-engine, it comes from ovirt-imageio which has not been released yet:

* 748bd64 - (HEAD -> master, origin/master, origin/HEAD) packaging: setup: Fix inconsistent options filling (4 settimane fa) <Ido Rosenzwig>
* b0a5ad0 - proxy: tests: add diff to isort tests (5 settimane fa) <Sandro Bonazzola>
* 7bb2894 - proxy: remove Content-Length from GET tests (7 settimane fa) <Daniel Erez>
* d6fd251 - daemon: catch PartialContent exception on upload (7 settimane fa) <Idan Shaby>
* 59277f8 - build: Fix make s/rpm on Fedora >= 27 (8 settimane fa) <Nir Soffer>
* e3d9c37 - (tag: v1.2.1) proxy: revert log commenting (9 settimane fa) <Daniel Erez>

Daniel, Nir, can you please issue a release ASAP?

--- Additional comment from Sandro Bonazzola on 2018-03-16 11:07:38 EDT ---

Cloning this bug to ovirt-imageio for making it visible.