Bug 1557580 - Review Request: perl-Spreadsheet-ParseXLSX - Parse XLSX files
Summary: Review Request: perl-Spreadsheet-ParseXLSX - Parse XLSX files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1557579
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-16 23:36 UTC by Elliott Sales de Andrade
Modified: 2018-03-30 13:08 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-28 23:48:19 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2018-03-16 23:36:14 UTC
Spec URL: https://qulogic.fedorapeople.org//perl-Spreadsheet-ParseXLSX.spec
SRPM URL: https://qulogic.fedorapeople.org//perl-Spreadsheet-ParseXLSX-0.27-1.fc27.src.rpm

Description:
This module is an adaptor for <Spreadsheet::ParseExcel> that reads XLSX files.
For documentation about the various data that you can retrieve from these
classes, please see <Spreadsheet::ParseExcel>,
<Spreadsheet::ParseExcel::Workbook>, <Spreadsheet::ParseExcel::Worksheet>, and
<Spreadsheet::ParseExcel::Cell>.

Comment 1 Robert-André Mauchin 🐧 2018-03-17 14:02:42 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: da4f1ab6e3dcb6322ae5ebfc7569d3272b70b27fdb206ee7fd6456097e4ff18c) is original. Ok.
Summary verified from lib/ParseXLSX.pm. Ok.
Description verified from lib/ParseXLSX.pm. Ok.
License verified from lib/ParseXLSX.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Spreadsheet-ParseXLSX.spec review-perl-Spreadsheet-ParseXLSX/results/perl-Spreadsheet-ParseXLSX-0.27-1.fc29.noarch.rpm review-perl-Spreadsheet-ParseXLSX/results/perl-Spreadsheet-ParseXLSX-0.27-1.fc29.src.rpm 
perl-Spreadsheet-ParseXLSX.noarch: W: spelling-error %description -l en_US adaptor -> adapter, adapt or, adapt-or
perl-Spreadsheet-ParseXLSX.noarch: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus
perl-Spreadsheet-ParseXLSX.noarch: W: incoherent-version-in-changelog 0.12-1 ['0.27-1.fc29', '0.27-1']
perl-Spreadsheet-ParseXLSX.src: W: spelling-error %description -l en_US adaptor -> adapter, adapt or, adapt-or
perl-Spreadsheet-ParseXLSX.src: W: spelling-error %description -l en_US ParseExcel -> Parse Excel, Parse-excel, Paracelsus
2 packages and 1 specfiles checked; 0 errors, 5 warnings.

$ rpm -q -lv -p perl-Spreadsheet-ParseXLSX-0.27-1.fc29.noarch.rpm 
drwxr-xr-x    2 root    root                        0 mars 17 14:51 /usr/share/doc/perl-Spreadsheet-ParseXLSX
-rw-r--r--    1 root    root                     4605 août 16  2016 /usr/share/doc/perl-Spreadsheet-ParseXLSX/Changes
-rw-r--r--    1 root    root                     3444 mars 17 14:50 /usr/share/man/man3/Spreadsheet::ParseXLSX.3pm.gz
-rw-r--r--    1 root    root                     1273 mars 17 14:50 /usr/share/man/man3/Spreadsheet::ParseXLSX::Decryptor.3pm.gz
-rw-r--r--    1 root    root                     1279 mars 17 14:50 /usr/share/man/man3/Spreadsheet::ParseXLSX::Decryptor::Agile.3pm.gz
-rw-r--r--    1 root    root                     1279 mars 17 14:50 /usr/share/man/man3/Spreadsheet::ParseXLSX::Decryptor::Standard.3pm.gz
drwxr-xr-x    2 root    root                        0 mars 17 14:50 /usr/share/perl5/vendor_perl/Spreadsheet
drwxr-xr-x    2 root    root                        0 mars 17 14:50 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX
-rw-r--r--    1 root    root                    40468 août 16  2016 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX.pm
drwxr-xr-x    2 root    root                        0 mars 17 14:50 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX/Decryptor
-rw-r--r--    1 root    root                     6537 août 16  2016 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX/Decryptor.pm
-rw-r--r--    1 root    root                     3273 août 16  2016 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX/Decryptor/Agile.pm
-rw-r--r--    1 root    root                     2701 août 16  2016 /usr/share/perl5/vendor_perl/Spreadsheet/ParseXLSX/Decryptor/Standard.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Spreadsheet-ParseXLSX-0.27-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(:VERSION) >= 5.10.0
      1 perl(Archive::Zip)
      1 perl(base)
      1 perl(Crypt::Mode::CBC)
      1 perl(Crypt::Mode::ECB)
      1 perl(Digest::SHA)
      1 perl(Encode)
      1 perl(File::Temp)
      1 perl(Graphics::ColorUtils)
      1 perl(MIME::Base64)
      1 perl(OLE::Storage_Lite)
      1 perl(Scalar::Util)
      1 perl(Spreadsheet::ParseExcel) >= 0.61
      1 perl(Spreadsheet::ParseXLSX::Decryptor)
      1 perl(Spreadsheet::ParseXLSX::Decryptor::Agile)
      1 perl(Spreadsheet::ParseXLSX::Decryptor::Standard)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XML::Twig)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Spreadsheet-ParseXLSX-0.27-1.fc29.noarch.rpm
perl(Spreadsheet::ParseXLSX) = 0.27
perl(Spreadsheet::ParseXLSX::Decryptor) = 0.27
perl(Spreadsheet::ParseXLSX::Decryptor::Agile) = 0.27
perl(Spreadsheet::ParseXLSX::Decryptor::Standard) = 0.27
perl-Spreadsheet-ParseXLSX = 0.27-1.fc29
Binary provides are Ok.

Package builds in mock. 

***You need to add your own entry in the changelog with the correct Version/Release***

Resolution: Package approved.

Comment 2 Gwyn Ciesla 2018-03-19 13:19:28 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Spreadsheet-ParseXLSX

Comment 3 Fedora Update System 2018-03-19 23:45:32 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-45b193ce05

Comment 4 Fedora Update System 2018-03-19 23:45:50 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-13a51231c8

Comment 5 Fedora Update System 2018-03-20 14:53:01 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-13a51231c8

Comment 6 Fedora Update System 2018-03-20 19:37:41 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-45b193ce05

Comment 7 Fedora Update System 2018-03-28 23:48:19 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2018-03-30 13:08:05 UTC
perl-Spreadsheet-ParseXLSX-0.27-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.