Spec URL: https://lupinix.fedorapeople.org/review/python2-astropy.spec SRPM URL: https://lupinix.fedorapeople.org/review/python2-astropy-2.0.5-2.fc27.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25763501 Description: The Astropy project is a common effort to develop a single core package for Astronomy. Major packages such as PyFITS, PyWCS, vo, and asciitable already merged in, and many more components being worked on. In particular, we are developing imaging, photometric, and spectroscopic functionality, as well as frameworks for cosmology, unit handling, and coordinate transformations. This package splits out the Python 2 parts from python-astropy package. The new astropy releases are Python 3 only, so the Python 2 bits have to be removed from python-astropy. As some packages, e.g. astrometry, and users still rely on the Python 2 part, we create a separate python2-astropy package containing the 2.x version of astropy. This is the last version supporting Python 2.x and will get upstream updates until end of 2019. Fedora Account System Username: lupinix
Additional info: This is mostly a split out from https://src.fedoraproject.org/rpms/python-astropy
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (unspecified)", "PSF (v2)", "LGPL (v3 or later)", "*No copyright* BSD (unspecified)", "BSD (3 clause)", "BSD (2 clause)", "GPL (v3)", "*No copyright* MIT/X11 (BSD like)". 1270 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python2-astropy/review- python2-astropy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-astropy-2.0.5-2.fc29.x86_64.rpm python2-astropy-doc-2.0.5-2.fc29.x86_64.rpm python2-astropy-debuginfo-2.0.5-2.fc29.x86_64.rpm python2-astropy-debugsource-2.0.5-2.fc29.x86_64.rpm python2-astropy-2.0.5-2.fc29.src.rpm python2-astropy.x86_64: W: spelling-error %description -l en_US asciitable -> ascertainable python2-astropy.x86_64: W: spelling-error %description -l en_US photometric -> photo metric, photo-metric, photometer python2-astropy.x86_64: W: hidden-file-or-dir /usr/lib64/python2.7/site-packages/astropy/utils/tests/data/.hidden_file.txt python2-astropy.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/astropy/utils/tests/data/test_package/data/foo.txt python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/astropy_wcs.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/astropy_wcs_api.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/distortion.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/isnan.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/pipeline.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/pyutil.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/sip.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs/util.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/include/astropy_wcs_api.h python2-astropy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/astropy/wcs/tests/extension/wcsapi_test.c python2-astropy-debugsource.x86_64: W: no-documentation python2-astropy.src: W: spelling-error %description -l en_US vo -> co, vi, v python2-astropy.src: W: spelling-error %description -l en_US asciitable -> ascertainable python2-astropy.src: W: spelling-error %description -l en_US photometric -> photo metric, photo-metric, photometer 5 packages and 0 specfiles checked; 1 errors, 17 warnings.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python2-astropy
python-pytest-arraydiff-0.2-1.fc28 python-pytest-openfiles-0.2.0-1.fc28 python-pytest-remotedata-0.2.0-1.fc28 python-pytest-doctestplus-0.1.2-1.fc28 python-pytest-astropy-0.2.1-1.fc28 python-astropy-healpix-0.2-1.fc28 python2-astropy-2.0.5-2.fc28 python-astropy-3.0.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ebae6c186
python-astropy-3.0.1-1.fc28, python-astropy-healpix-0.2-1.fc28, python-pytest-arraydiff-0.2-1.fc28, python-pytest-astropy-0.2.1-1.fc28, python-pytest-doctestplus-0.1.2-1.fc28, python-pytest-openfiles-0.2.0-1.fc28, python-pytest-remotedata-0.2.0-1.fc28, python2-astropy-2.0.5-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ebae6c186
python-astropy-3.0.1-1.fc28, python-astropy-healpix-0.2-1.fc28, python-pytest-arraydiff-0.2-1.fc28, python-pytest-astropy-0.2.1-1.fc28, python-pytest-doctestplus-0.1.2-1.fc28, python-pytest-openfiles-0.2.0-1.fc28, python-pytest-remotedata-0.2.0-1.fc28, python2-astropy-2.0.5-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.