Bug 1557770 - Webadmin-imageIO - 'Cancel' option should be removed from download disk
Summary: Webadmin-imageIO - 'Cancel' option should be removed from download disk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.2.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.4
: ---
Assignee: Idan Shaby
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-18 14:05 UTC by Avihai
Modified: 2018-06-26 08:38 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.2.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 08:38:32 UTC
oVirt Team: Storage
rule-engine: ovirt-4.2+
ylavi: exception+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 90373 0 master MERGED frontend: remove the cancel image download button 2018-05-10 11:34:04 UTC
oVirt gerrit 90845 0 master MERGED core: rename ImageTransferPhase::canBeResumed 2018-05-10 11:33:58 UTC
oVirt gerrit 90846 0 master MERGED backend: forbid paused states for download flows 2018-05-10 11:34:01 UTC
oVirt gerrit 91240 0 ovirt-engine-4.2 MERGED core: rename ImageTransferPhase::canBeResumed 2018-05-16 10:11:01 UTC
oVirt gerrit 91241 0 ovirt-engine-4.2 MERGED backend: forbid paused states for download flows 2018-05-16 10:11:06 UTC
oVirt gerrit 91242 0 ovirt-engine-4.2 MERGED frontend: remove the cancel image download button 2018-05-16 10:11:10 UTC

Description Avihai 2018-03-18 14:05:27 UTC 
Description of problem:
As part of bug 1539363, download operation is now canceled automatically so no need for this option in webadmin - please remove it .

Version-Release number of selected component (if applicable):
4.2.2.4-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1.Webadmin -> disks -> choose a disk -> download

Actual results:
Cancel option is there

Expected results:
Cancel option should not be there

Additional info:
Comment 1 Daniel Erez 2018-03-18 14:57:32 UTC 
@Idan - iirc, we've kept the cancel button just to allow cancellation of old downloads that were stuck in paused status. Maybe we can just automatically cancel those downloads as well? I.e. add to the auto cancel mechanism support for paused downloads? Or is it problematic?
Comment 2 Idan Shaby 2018-03-19 08:16:24 UTC 
I can't think of anything problematic here, so I guess that it can be pretty easy to implement.
Comment 3 Avihai 2018-05-28 08:12:38 UTC 
Verified on engine 4.2.4-0.1
Comment 4 Sandro Bonazzola 2018-06-26 08:38:32 UTC 
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.