Bug 1557803 - no name validation during the create template stage
Summary: no name validation during the create template stage
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.2.1.7
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Sharon Gratch
QA Contact: Pavel Stehlik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-18 21:35 UTC by nicolas vaye
Modified: 2018-05-09 10:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-09 10:43:34 UTC
oVirt Team: Virt
Embargoed:


Attachments (Terms of Use)
the video of my screen to explain the problem (942.29 KB, video/mp4)
2018-03-18 21:35 UTC, nicolas vaye
no flags Details

Description nicolas vaye 2018-03-18 21:35:49 UTC
Created attachment 1409593 [details]
the video of my screen to explain the problem

Description of problem:

I 'have 2 ovirt node with HE in version 4.2.1.7-1.

If i make a template from a VM's snapshot in the web ui, there is a form ui to enter several parameter
if the name of the template is missing and if we clic on the OK button, there is an highlighting red border on the name to indicate the problem.
if i enter a long name for the template and if we clic on the OK button, nothing happend, and there is no highlight or error message to indicate there is a problem with the long name.
May be a problem with the name ??

Version-Release number of selected component (if applicable):


How reproducible:
see the video in attachment.

Steps to Reproduce:
see the video in attachment.

Actual results:


Expected results:


Additional info:

Comment 1 nicolas vaye 2018-03-18 21:37:09 UTC
Alexander Wels (awels) said :

Interesting, as that name is not long enough to trigger the name length 
validation. You have 64 characters total for the name. I just tried your 
scenario on the latest master branch, and it worked as expected, it created 
the template from the snapshot without issues with that exact same name.

I don't see any recent changes to the frontend code for that dialog either. If 
you look in the engine.log does it say anything? I can only assume some 
validation is failing, and that validation message is not properly propagated 
to the frontend, but it should show something in the backend log regardless.

Comment 2 nicolas vaye 2018-03-18 21:43:22 UTC
No information in the engine.log during the test.

Comment 3 Yaniv Kaul 2018-03-19 07:24:39 UTC
Could it be browser dependent? Which browser are you using? Is there something special in the name?
(lowering severity though - doesn't strike me as a high severity issue)

Comment 4 nicolas vaye 2018-03-19 21:14:16 UTC
my test was done on firefox quantum 58.0.1 (64 bits), firefox 45.5 esr, chrome 41 and it is always the same result.

no special in the name, i enter : template__windows_2012_stdR2

Comment 5 Michael 2018-03-22 12:56:54 UTC
Hi guys,
I've experienced the same issue.

The name I wanted to use as a name during creation was something along the line of: aa-bbbbb-ccc-dd-eeee-v1 (obfuscated).

This didn't work and there was no feedback other than nothing happening when I clicked the OK button. If I used a shorter name of the "aa-ccc-v1" then it worked fine.

I am also perfectly able to rename the alread-created template to the shape "aa-bbbbb-ccc-dd-eeee-v1", but this means I'm not able to create a Sub-Versioned template, even if using the shorter name (probably because the base template name is invalid).

If I rename the base template, v1, to aa-ccc-v1, I am able to create a aa-ccc-v2 sub-versioned template using the v1 as the base.
Once created I am able to rename the templates to "aa-bbbbb-ccc-dd-eeee-v1" and "aa-bbbbb-ccc-dd-eeee-v2".


Keep up the good work :)
//Mike

Comment 6 Michal Skrivanek 2018-04-16 12:26:59 UTC
can you please take a look? It's just a medium priority, but let's target it once the issue is understood

Comment 7 Sharon Gratch 2018-04-23 09:43:09 UTC
(In reply to Michal Skrivanek from comment #6)
> can you please take a look? It's just a medium priority, but let's target it
> once the issue is understood

I tried all mentioned scenarios on master branch (both mentioned names, a name with invalid characters, name longer than 64 chars, an already existing name..) and all worked as expected. I can't reproduce this issue.

Comment 8 Sharon Gratch 2018-04-23 11:26:00 UTC
(In reply to Michael from comment #5)
Hi Michael, 
since it is not reproduced for us, can you please send the engine log once the issue is reproduced for you?

Comment 9 Michael 2018-04-23 12:08:18 UTC
(In reply to Sharon Gratch from comment #8)
> (In reply to Michael from comment #5)
> Hi Michael, 
> since it is not reproduced for us, can you please send the engine log once
> the issue is reproduced for you?

Hi Sharon,

Thank you for looking into the bug. I am no longer able to reproduce the error either. Are you releasing updates every now and then? If not, perhaps the issue was related to something else... mystery! :)

I'll keep the bug in mind and refer to it, if I see it happen again.


Have a nice day,
Michael

Comment 10 Sharon Gratch 2018-04-23 13:52:03 UTC
Hi Nicolas, 
Is this issue still reproduced and if so then can you please send the engine log? Maybe we can get some info on the problem from the log...

Comment 11 nicolas vaye 2018-04-23 21:31:23 UTC
Hi Sharon,

since the bug was reported, i update HE and node. I've not access to the platform this week, but next week i'll take a look to see if the bug disappear or not.

See you next week.

Nicolas

Comment 12 nicolas vaye 2018-05-09 01:26:13 UTC
Hi,

sorry for the delay.
I have tested again on ovirt 4.2.3, and everything works fine.
Can't reproduce.

You can closed this issue.

Thanks.


Nicolas VAYE

Comment 13 Sharon Gratch 2018-05-09 10:43:34 UTC
(In reply to nicolas vaye from comment #12)
> Hi,
> 
> sorry for the delay.
> I have tested again on ovirt 4.2.3, and everything works fine.
> Can't reproduce.
> 
> You can closed this issue.
> 
> Thanks.
> 
> 
> Nicolas VAYE
Nicolas, thanks for the update.

So since it is not reproduced anymore- I'm closing this bug.


Note You need to log in before you can comment on or make changes to this bug.