Bug 1558082 - "Are you sure?" dialog should pop when one close the wizard in the middle of the installation
Summary: "Are you sure?" dialog should pop when one close the wizard in the middle of ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Hosted Engine
Version: 0.11.17
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.5
: 0.11.29
Assignee: Phillip Bailey
QA Contact: Yihui Zhao
URL:
Whiteboard:
Depends On:
Blocks: cockpit-ovirt-0.11.30
TreeView+ depends on / blocked
 
Reported: 2018-03-19 15:13 UTC by Ido Rosenzwig
Modified: 2018-07-31 15:31 UTC (History)
10 users (show)

Fixed In Version: cockpit-ovirt-0.11.29-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-31 15:31:12 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.2+
ylavi: exception+
ycui: testing_ack+


Attachments (Terms of Use)
Functioning dialog - Chrome (391.93 KB, video/mp4)
2018-06-05 14:06 UTC, Phillip Bailey
no flags Details
Functioning dialog - Firefox (395.87 KB, video/mp4)
2018-06-05 14:07 UTC, Phillip Bailey
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 91718 0 master MERGED wizard: Confirm close request in HE wizard 2018-05-30 14:21:17 UTC
oVirt gerrit 91806 0 ovirt-4.2 MERGED wizard: Confirm close request in HE wizard 2018-05-30 14:23:14 UTC
oVirt gerrit 91972 0 ovirt-4.2 MERGED wizard: Fix confirm close dialog prompt 2018-06-25 15:01:50 UTC

Description Ido Rosenzwig 2018-03-19 15:13:41 UTC
Description of problem:
The wizard can be closed too easily when installation is in progress.
When pressing the 'close' or  'X' buttons the wizard closes no questions asked.

it would be nice to add a "Are you sure?" dialog.

Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard-0.11.17

How reproducible:
100%

Steps to Reproduce:
1.login to cockpit and start the wizard for hosted-engine installation
2.press close or 'X' buttons
3.the wizard exits no questions asked

Actual results:
wizard exits no questions asked

Expected results:
"are you sure?" dialog should pop up

Comment 1 Yihui Zhao 2018-06-05 02:18:26 UTC
Test with cockpit-ovirt-dashboard-0.11.27-1.el7ev.noarch:


1. When clicked the "X" close button, it will pop the dialog "Are you sure you want to exit the wizard?". If clicked the "No", return the HE wizard, clicked the "Yes", return the Start page.  This scenario works well


2. When clicked the "Cancel" button, it also pops the dialog "Are you sure you want to exit the wizard?". If clicked the "No" button, cockpit didn't return the HE wizard.

Comment 2 Phillip Bailey 2018-06-05 14:06:48 UTC
Created attachment 1447865 [details]
Functioning dialog - Chrome

Comment 3 Phillip Bailey 2018-06-05 14:07:13 UTC
Created attachment 1447866 [details]
Functioning dialog - Firefox

Comment 4 Yihui Zhao 2018-07-02 05:51:18 UTC
Tested with cockpit-ovirt-0.11.29-1, it works well for me.

Will change the bug's status to verified while it becomes ON_QA.

Comment 5 Yihui Zhao 2018-07-06 02:08:09 UTC
According to Comment 4, change this bug's status to verified.

Comment 6 Sandro Bonazzola 2018-07-31 15:31:12 UTC
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.