Due to a recent update on Javascript code a full page refresh on your browser might be needed.
Bug 1558335 - gluster-block: discontinue gerrit
Summary: gluster-block: discontinue gerrit
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-20 04:30 UTC by Prasanna Kumar Kalever
Modified: 2018-04-12 14:58 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-12 14:58:05 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Prasanna Kumar Kalever 2018-03-20 04:30:03 UTC
Description of problem:

Use github [1] for patch reviews and creating issue.

[1] https://github.com/gluster/gluster-block/

Comment 1 Atin Mukherjee 2018-03-20 07:30:44 UTC
FWIW (and out of curiosity too), it'd be worth to mention why did we decide to move away from gerrit :-)

Comment 2 Nigel Babu 2018-03-20 09:14:11 UTC
Okay, I'm creating this checklist on the fly here.

1. Do you have a team on github with the correct people having commit access?
[Yes/No]

2. Are all your existing review requests closed on github?
[Yes/No]

3. Do you expect new review requests on gerrit to be rejected?
[Yes/No]

4. I will be switching your Gerrit repo to read-only and removing the sync to Github. Please acknowledge that this is okay.
[Yes/No]

Comment 3 Prasanna Kumar Kalever 2018-03-20 09:56:19 UTC
(In reply to Atin Mukherjee from comment #1)
> FWIW (and out of curiosity too), it'd be worth to mention why did we decide
> to move away from gerrit :-)

1. Currently the upstream RFE's/issues/bugs/milestones are tracked in github, where as we encourage patches to be pushed to gerrit only. It is good to have everything at one place (As a fact supporting both is not possible)

2. Not everyone knows gerrit, for example we see new contributors directly send patches to github and asking them to send to gerrit looks an extra hop.

3. Personally, I do not see a real benefit in using gerrit and not github.

4. Also having everything at one place give us opportunity to address/answer the github issues faster (as we look at github more often than before)

Others can add/correct.

Comment 4 Prasanna Kumar Kalever 2018-03-20 10:01:45 UTC
(In reply to Nigel Babu from comment #2)
> Okay, I'm creating this checklist on the fly here.
> 
> 1. Do you have a team on github with the correct people having commit access?
> [Yes/No]

Yes

> 
> 2. Are all your existing review requests closed on github?
> [Yes/No]

do you mean to ask in gerrit ?

We have open issues in github and gerrit, but all the commits are from within the team, so we can manage to send new review request and abandon the older once.

Not sure if that answers your question though. 

> 
> 3. Do you expect new review requests on gerrit to be rejected?
> [Yes/No]

Yes, may be with some good message if possible.

> 
> 4. I will be switching your Gerrit repo to read-only and removing the sync
> to Github. Please acknowledge that this is okay.
> [Yes/No]

Yes.

@pranith, @vijay
Please acknowledge.

Thanks!

Comment 5 Pranith Kumar K 2018-03-20 10:06:50 UTC
(In reply to Prasanna Kumar Kalever from comment #3)
> (In reply to Atin Mukherjee from comment #1)
> > FWIW (and out of curiosity too), it'd be worth to mention why did we decide
> > to move away from gerrit :-)
> 
> 1. Currently the upstream RFE's/issues/bugs/milestones are tracked in
> github, where as we encourage patches to be pushed to gerrit only. It is
> good to have everything at one place (As a fact supporting both is not
> possible)
> 
> 2. Not everyone knows gerrit, for example we see new contributors directly
> send patches to github and asking them to send to gerrit looks an extra hop.
> 
> 3. Personally, I do not see a real benefit in using gerrit and not github.
> 
> 4. Also having everything at one place give us opportunity to address/answer
> the github issues faster (as we look at github more often than before)
> 
> Others can add/correct.

This was also asked multiple times by heketi team. So we also felt like it is better.

Comment 6 Nigel Babu 2018-04-12 14:58:05 UTC
This is complete


Note You need to log in before you can comment on or make changes to this bug.