Spec URL: https://raw.githubusercontent.com/RussianFedora/openhantek/master/openhantek.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1378/25831378/openhantek-0.0.1-0.20180315git52622ac.fc29.src.rpm Description: OpenHantek is a free software for Hantek and compatible (Voltcraft/Darkwire/Protek/Acetech) USB digital signal oscilloscopes. Homepage http://openhantek.org
- I couldn't find a Release number on the website, how did you find 0.0.1? If upstream hasn't decided a Release number, set it to 0. Also Release should start at 1, not 0. Version: 0.0.1 Release: 0.%{date}git%{gitcommit}%{?dist} Maybe you could convince upstream to start tagging release properly. - The changelog entry should contain a valid release message, for example "Initial package for Fedora". - Not needed, it is automated by transfiletrigger: %post %{udev_rules_update} %postun %{udev_rules_update}
Spec URL: https://raw.githubusercontent.com/RussianFedora/openhantek/master/openhantek.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5104/25835104/openhantek-0-1.20180315git52622ac.fc29.src.rpm Version 0.0.1 - is my guess. Now corrected. I contacted upstream about it https://github.com/OpenHantek/openhantek/issues/210 Changelog entry added. %post and %postun deleted. I use it for f27 build.
I will review this package.
> Version: 0 Upstream have 2017-12 Git version tag. > install -p -D -m 644 %{name}/res/images/%{name}.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png > install -p -D -m 644 %{name}/res/images/%{name}.svg %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/%{name}.svg You can install only SVG icon.
Spec URL: https://raw.githubusercontent.com/RussianFedora/openhantek/master/openhantek.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8516/26258516/openhantek-0-1.20180320git0eff8d4.fc29.src.rpm Removed PNG icon.
It contain blob copyright firmware.