Bug 1558614 - OVA import does not set CPU topology correctly.
Summary: OVA import does not set CPU topology correctly.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.2.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.4
: ---
Assignee: Shmuel Melamud
QA Contact: Liran Rotenberg
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-20 15:46 UTC by Nisim Simsolo
Modified: 2018-06-26 08:37 UTC (History)
6 users (show)

Fixed In Version: ovirt-engine-4.2.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 08:37:39 UTC
oVirt Team: Virt
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
vdsm.log (635.91 KB, application/x-xz)
2018-03-20 16:41 UTC, Nisim Simsolo
no flags Details
engine.log (4.41 MB, text/plain)
2018-03-20 16:42 UTC, Nisim Simsolo
no flags Details
ovirt-export-ova-ansible log (20.00 KB, text/plain)
2018-03-20 16:43 UTC, Nisim Simsolo
no flags Details
ovirt-export-ova-validate-ansible log (4.36 KB, text/plain)
2018-03-20 16:43 UTC, Nisim Simsolo
no flags Details
ovirt-query-ova-ansible log (14.50 KB, text/plain)
2018-03-20 16:44 UTC, Nisim Simsolo
no flags Details
ovirt-import-ova-ansible log (1.06 KB, text/plain)
2018-03-20 16:44 UTC, Nisim Simsolo
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 91109 0 master MERGED webadmin: Clone VM.threadsPerCpu 2018-05-10 06:04:34 UTC
oVirt gerrit 91129 0 ovirt-engine-4.2 MERGED webadmin: Clone VM.threadsPerCpu 2018-05-10 11:13:32 UTC

Description Nisim Simsolo 2018-03-20 15:46:58 UTC
Description of problem:
When importing RHV OVA file with 4 virtual CPUs, 2 virtual sockets and 2 threads per core (2:1:2), the imported VM CPU topology is 4 virtual CPUs 4 virtual sockets, 1 core per virtual socket and 1 threads per core (4:1:1).

In the exported OVA file, the parameters are correct:
<rasd:Caption>4 virtual cpu</rasd:Caption>
<rasd:Description>Number of virtual CPU</rasd:Description><rasd:InstanceId>1</rasd:InstanceId>
<rasd:ResourceType>3</rasd:ResourceType><rasd:num_of_sockets>2</rasd:num_of_sockets><rasd:cpu_per_socket>1</rasd:cpu_per_socket><rasd:threads_per_cpu>2</rasd:threads_per_cpu><rasd:max_num_of_vcpus>32</rasd:max_num_of_vcpus>

Version-Release number of selected component (if applicable):
rhvm-4.2.2.4-0.1.el7
vdsm-4.20.22-1.el7ev.x86_64
libvirt-client-3.9.0-14.el7.x86_64
qemu-kvm-rhev-2.10.0-19.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Export VM as OVA with CPU topology of 2:1:2
2. Import this VM
3. Observe CPU topology

Actual results:
Imported VM CPU topology is 4:1:1 instead of 2:1:2

Expected results:
CPU topology should be 2:1:2

Additional info:
ovirt-query-ova-ansible.log, ovirt-import-ova-ansibl.log, vdsm.log and engine.log (import started at 2018-03-20 17:02:57,416+02) attached

Comment 1 Nisim Simsolo 2018-03-20 16:41:50 UTC
Created attachment 1410617 [details]
vdsm.log

Comment 2 Nisim Simsolo 2018-03-20 16:42:30 UTC
Created attachment 1410620 [details]
engine.log

Comment 3 Nisim Simsolo 2018-03-20 16:43:12 UTC
Created attachment 1410632 [details]
ovirt-export-ova-ansible log

Comment 4 Nisim Simsolo 2018-03-20 16:43:37 UTC
Created attachment 1410633 [details]
ovirt-export-ova-validate-ansible log

Comment 5 Nisim Simsolo 2018-03-20 16:44:10 UTC
Created attachment 1410634 [details]
ovirt-query-ova-ansible log

Comment 6 Nisim Simsolo 2018-03-20 16:44:53 UTC
Created attachment 1410635 [details]
ovirt-import-ova-ansible log

Comment 7 Michal Skrivanek 2018-03-21 08:59:04 UTC
OvfReader::readCpuItem() 

vmBase.setCpuPerSocket(Integer.parseInt(selectSingleNode(node, "rasd:cpu_per_socket", _xmlNS).innerText));

vs

vmBase.setThreadsPerCpu(parseNodeInteger(node, "rasd:threads_per_cpu", 1))

?

Comment 8 Liran Rotenberg 2018-06-13 06:57:05 UTC
Verified on:
ovirt-engine-4.2.4.2-0.1.el7_3.noarch
vdsm-4.20.30-1.el7ev.x86_64

Steps of verfication:
1. Export VM as OVA with CPU topology of 2:1:2
2. Import this VM
3. Observe CPU topology

Actual results:
Imported VM CPU topology is 2:1:2 as expected.

Comment 9 Sandro Bonazzola 2018-06-26 08:37:39 UTC
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.