Bug 1558847 - [RFE] Sync all networks across all hosts in cluster
Summary: [RFE] Sync all networks across all hosts in cluster
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.6
: 4.2.6.2
Assignee: eraviv
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-21 06:39 UTC by eraviv
Modified: 2018-11-20 06:15 UTC (History)
9 users (show)

Fixed In Version: ovirt-engine-4.2.6.2
Doc Type: Enhancement
Doc Text:
Previously, if a host's networks network definitions became unsynchronized with the definitions on the Manager, there was no way to synchronize all unsynchronized hosts on the cluster level. In this release, a new Sync All Networks button has been added to the Cluster screen in the Administration Portal that enables users to synchronize all unsynchronized hosts with the definitions defined on the Manager.
Clone Of:
Environment:
Last Closed: 2018-09-03 15:07:52 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.2+
mburman: testing_plan_complete-
ylavi: planning_ack+
danken: devel_ack+
myakove: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 89640 0 master MERGED core: sync all networks in cluster 2020-04-28 06:39:36 UTC
oVirt gerrit 89641 0 master MERGED restapi: sync all networks in cluster 2020-04-28 06:39:36 UTC
oVirt gerrit 89642 0 master MERGED webadmin: sync all networks in cluster 2020-04-28 06:39:36 UTC
oVirt gerrit 90211 0 master MERGED api-model: Add 'sync all networks in cluster' 2020-04-28 06:39:36 UTC
oVirt gerrit 91712 0 master MERGED restapi: Update to model 4.3.11 2020-04-28 06:39:36 UTC
oVirt gerrit 93294 0 model_4.2 MERGED api-model: Add 'sync all networks in cluster' 2020-04-28 06:39:36 UTC
oVirt gerrit 93303 0 ovirt-engine-4.2 MERGED core: sync all networks in cluster 2020-04-28 06:39:37 UTC
oVirt gerrit 93304 0 ovirt-engine-4.2 MERGED webadmin: sync all networks in cluster 2020-04-28 06:39:37 UTC
oVirt gerrit 93305 0 ovirt-engine-4.2 MERGED restapi: sync all networks in cluster 2020-04-28 06:39:37 UTC
oVirt gerrit 93565 0 master MERGED api-model: sync all networks in cluster - adjust since version 2020-04-28 06:39:37 UTC
oVirt gerrit 93612 0 ovirt-engine-4.2 MERGED restapi: Update to model 4.2.36 2020-04-28 06:39:37 UTC

Description eraviv 2018-03-21 06:39:57 UTC
Description of problem:
Currently it is not possible to sync all the hosts which are out of sync with a single click.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
After implementation, a button with 'Sync all hosts' will enable this action

Additional info:

Comment 1 Yaniv Kaul 2018-03-22 07:40:36 UTC
A simple Ansible playbook can be used perhaps?

Comment 3 Dan Kenigsberg 2018-07-25 06:31:39 UTC
Eitan, please fill in the Doc Text with a draft documentation. requires_doc_text should be set to + only by the Docs team, after they have properly addressed our require_doc_text? request.

Specifically, I think that we should modify https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2/html/administration_guide/chap-logical_networks#Editing_a_Logical_Network to mention your new button.

Comment 4 Dan Kenigsberg 2018-08-14 21:42:28 UTC
Can also be tested with any nightly build virt-engine-0:4.2.6.3_SNAPSHOT-*

Comment 5 Michael Burman 2018-08-16 11:10:38 UTC
Verified on - 

Few notes:

1. It is still missing indication in the UI for the cluster level that networks are out of sync in the cluster. The only way to know that networks are out-of-sync are on the host level. 
BZ  1613702 should provide some indication(a warning icon next to the cluster) that networks are out-of-sync in the cluster. There is column for it in the Clusters main tab.

2. "Sync all hosts in cluster" invokes the pre-existing "sync all host networks" operation per each host in the cluster.
"sync all host networks" in turn invokes "setup networks" without checking if the host is in\out of sync.
This means that even for hosts that are in good state in the cluster we will see 2 audit logs about changes applied on the host and changes succeeded on the host, even if the state on the host is good and all networks are in sync.
"Sync all hosts in cluster" only writes a single additional audit log message that the operation has started ("Started sync of all cluster ${ClusterName} networks.")
Followed by "Managed to sync all host $[{hostname} networks." when done.

Comment 6 Michael Burman 2018-08-16 11:20:04 UTC
Verified on - 4.2.6.3_SNAPSHOT-94.gbbcd5cb.0.scratch.master.el7ev

Few notes:

1. It is still missing indication in the UI for the cluster level that networks are out of sync in the cluster. The only way to know that networks are out-of-sync are on the host level. Or inside the cluster entity in the logical networks sub tab, the 'sync all networks' button will be enabled.
BZ  1613702 should provide some indication(a warning icon next to the cluster) that networks are out-of-sync in the cluster. There is column for it in the Clusters main tab.

2. "Sync all hosts in cluster" invokes the pre-existing "sync all host networks" operation per each host in the cluster.
"sync all host networks" in turn invokes "setup networks" without checking if the host is in\out of sync.
This means that even for hosts that are in good state in the cluster we will see 2 audit logs about changes applied on the host and changes succeeded on the host, even if the state on the host is good and all networks are in sync.
"Sync all hosts in cluster" only writes a single additional audit log message that the operation has started ("Started sync of all cluster ${ClusterName} networks.")
Followed by "Managed to sync all host $[{hostname} networks." when done.

3. If there is a problematic host in the cluster while invoking sync all host in cluster, there will be 2 audit messages that changes has failed to applied and sync has failed.

Comment 7 Michael Burman 2018-08-16 12:03:26 UTC
Worth to mention that indication for problematic out of sync hosts are available in the events log when the host is active and the events drawer is open.

Comment 8 Emma Heftman 2018-08-20 12:15:26 UTC
Eitan/Michael

copying over comments from Jira:
"the indications will be as follows (pending final approval from UX team):

    cluster hosts list view: textual indication in host status column
    hosts list view: textual indication in host status column
    host network interfaces view: graphical + textual indication on interfaces
    network hosts list view: graphical + tooltip indication in 'out-of-sync' column"


Are these UI changes part of a separate bug? This bug has already been verified so how are there still issues that need to be approved?

Comment 9 eraviv 2018-08-21 07:09:22 UTC
Dan, can you answer Emma?

Comment 10 Dan Kenigsberg 2018-08-27 15:33:32 UTC
Eitan, you are the one who listed these indications; you are in best position to answer if they are included in this current code. I don't understand what you need from me.

To the best of my knowledge the only change included with this bug is the added button, which becomes enabled when the cluster is somehow out-of-sync.

If you think that something should be added, you should file a new bug, much like what Burman did with bug 1613702.

Comment 11 Dan Kenigsberg 2018-08-28 09:02:42 UTC
I do not know why something has automatically set requires_doc_text to plus. I believe it should happen only after an intervention of a human technical writer. Can you tell where is the bug, Derek?

 Red Hat Bugzilla 2018-07-25 14:03:33 IDT
Flags: requires_doc_text? → requires_doc_text+

Comment 13 eraviv 2018-09-02 07:49:35 UTC
Emma, 

would you also mention in the docs that this new capability will also be available via the REST API?

Thanks


Note You need to log in before you can comment on or make changes to this bug.